Skip to content

fix(deriver): word-boundary matching in violatesPrivacy — short People slugs block every hypothesis #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pfassmeyer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deriver): word-boundary matching in violatesPrivacy — short People slugs block every hypothesis #1921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions LifeOS/install/LIFEOS/TOOLS/LearningPatternSynthesis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,12 +442,24 @@ function listPeopleSlugs(): Set<string> {
}

function violatesPrivacy(text: string, peopleSlugs: Set<string>): boolean {
// Word-boundary matching, not substring. KNOWLEDGE/People can legitimately
// contain very short slugs (an initial, a nickname); with `includes()`, a
// single-letter slug matches almost any text, so every candidate hypothesis
// is privacy-blocked and the deriver silently never emits — the failure mode
// is a clean `emitted=0`, indistinguishable from "nothing to report".
// Boundary matching preserves the guard's intent: claims that actually name
// a person still block.
const norm = text.toLowerCase();
for (const slug of peopleSlugs) {
// Slug typically `firstname-lastname`; check for both joined and space-separated.
const flat = slug.replace(/-/g, "");
const spaced = slug.replace(/-/g, " ");
if (norm.includes(spaced) || norm.includes(flat)) return true;
// Slug may be `firstname-lastname` or `firstname_lastname`; check the
// separator-normalized and joined forms.
const spaced = slug.replace(/[-_]/g, " ").trim();
const flat = slug.replace(/[-_]/g, "");
for (const needle of new Set([spaced, flat])) {
if (!needle) continue;
const esc = needle.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
if (new RegExp(`\\b${esc}\\b`, "i").test(norm)) return true;
}
}
return false;
}
Expand Down