Skip to content

fix: use "http" URL scheme only if no TLS is used#905

Merged
wolveix merged 1 commit intodanielgtaylor:mainfrom
leonklingele:fix/use-https-for-https-localhost
Jan 16, 2026
Merged

fix: use "http" URL scheme only if no TLS is used#905
wolveix merged 1 commit intodanielgtaylor:mainfrom
leonklingele:fix/use-https-for-https-localhost

Conversation

@leonklingele
Copy link
Copy Markdown
Contributor

This fixes an issue where the "http" schema was incorrectly used for the "$schema" value when https://localhost or https://127.0.0.1 was requested.

This fixes an issue where the "http" schema was used in the "$schema" value
when https://localhost or https://127.0.0.1 is requested.
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.56%. Comparing base (689a87d) to head (e8e5098).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files          23       23           
  Lines        5511     5511           
=======================================
  Hits         5101     5101           
  Misses        351      351           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wolveix wolveix merged commit 57b3625 into danielgtaylor:main Jan 16, 2026
4 checks passed
@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented Jan 16, 2026

Thank you!

@leonklingele
Copy link
Copy Markdown
Contributor Author

@danielgtaylor is back in business! 🥳🥳🥳🥳🥳

@leonklingele
Copy link
Copy Markdown
Contributor Author

Oh wait! @wolveix, are you a new maintainer of huma?

@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented Jan 16, 2026

I am! I volunteered to help lighten the load 🙏

@leonklingele
Copy link
Copy Markdown
Contributor Author

That's so nice to see, @wolveix ❤️ Not trying to discredit @danielgtaylor's absolutely amazing work on huma -- does it make sense to create some kind of humago GitHub org and move the repo(s)? I'd love to be more involved in the future, too, and would be very interested in helping maintain huma. Really trying to make this the # 1 HTTP framework. So many opportunities to make huma even more fun to use. :)

@wolveix
Copy link
Copy Markdown
Collaborator

wolveix commented Jan 16, 2026

Couldn't agree more with you! I've been pushing Huma anywhere and everywhere for the past 2 years.

Regarding the org, I'll leave that entirely to @danielgtaylor. I think it's fine either way I think. Long-term an org would probably be better, but I'm not sure it's necessary right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants