fix: use "http" URL scheme only if no TLS is used#905
fix: use "http" URL scheme only if no TLS is used#905wolveix merged 1 commit intodanielgtaylor:mainfrom
Conversation
This fixes an issue where the "http" schema was used in the "$schema" value when https://localhost or https://127.0.0.1 is requested.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 23 23
Lines 5511 5511
=======================================
Hits 5101 5101
Misses 351 351
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you! |
|
@danielgtaylor is back in business! 🥳🥳🥳🥳🥳 |
|
Oh wait! @wolveix, are you a new maintainer of |
|
I am! I volunteered to help lighten the load 🙏 |
|
That's so nice to see, @wolveix ❤️ Not trying to discredit @danielgtaylor's absolutely amazing work on |
|
Couldn't agree more with you! I've been pushing Huma anywhere and everywhere for the past 2 years. Regarding the org, I'll leave that entirely to @danielgtaylor. I think it's fine either way I think. Long-term an org would probably be better, but I'm not sure it's necessary right now :) |
This fixes an issue where the "http" schema was incorrectly used for the "$schema" value when https://localhost or https://127.0.0.1 was requested.