Add missing dark theme socials icons#140
Open
IgorWnek wants to merge 3 commits intodanielcranney:mainfrom
Open
Add missing dark theme socials icons#140IgorWnek wants to merge 3 commits intodanielcranney:mainfrom
IgorWnek wants to merge 3 commits intodanielcranney:mainfrom
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @danielcranney on Vercel. @danielcranney first needs to authorize it. |
Owner
|
Thansk @IgorWnek there are some good ideas in here, but unfortunately the '-dark' icons should be light-coloured (so thqt they show on dark mode). |
Author
|
Thanks for the response. I'll take a look in a spare time and let you know. Will that be ok if I fix those icons? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR is opened as a response to #139 issue which I recently added.
It adds missing dark theme socials icons.
Icons are added from https://simpleicons.org/
Also I have removed unused imports.