Convert bUnit test interactions to async#90
Merged
Merged
Conversation
Changed ClickAsync, InputAsync, ChangeAsync, and WaitForAssertionAsync where the async API can complete normally, and updated affected tests to async Task. I intentionally left a small set of Click() calls synchronous in DataPointViewTests.razor and ManageCategoriesTests.razor: those buttons open dialogs/message boxes whose handlers await dialog.Result, so await ClickAsync() blocks until the dialog closes and hangs the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates bUnit test interactions to use async dispatch APIs where they can complete normally, including
ClickAsync,InputAsync,ChangeAsync, andWaitForAssertionAsync.A few dialog-opening clicks remain synchronous with comments because those handlers await dialog or message-box results, so
ClickAsyncwould block until the dialog closes and hang the test.