Refactor runtime resolution pipeline to Effect-based immutable state transitions#97
Open
danielbdyer wants to merge 1 commit into
Open
Refactor runtime resolution pipeline to Effect-based immutable state transitions#97danielbdyer wants to merge 1 commit into
danielbdyer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Object.assign,accRef.current) and surface an immutable pipeline state to improve reasoning and enable pure state transitions.Description
runResolutionPipelineand internalrunPipelinePhasesto return anEffect.Effectinstead ofPromise, and adapt the runtime wrapper to callEffect.runPromisewhen invoking the pipeline.PipelineStateandPipelineProgresscarryingstage,accumulator, andemittedEvents, and replace mutable stage updates with pure transition helpersmergeStage,withInterpretation, andappendReceiptEvent.PipelineProgress→Effectand fold the phases usingEffect.reduce; replace the prior imperative strategy chain/accumulator mutation withrunStrategiescomposed from Effect-returning attempts.PipelineDagValidationErrorandStrategyTotalityErrorfor DAG validation and missing-rung failures respectively, preserving existing precedence checks and event emission semantics.Effect.runPromise, and add law-style determinism tests that assert identical receipts and event ordering for representative overlay and needs-human fallback scenarios.Testing
npm run typesand the build/type projection succeeded.npm test -- tests/runtime-agent-pipeline.spec.ts tests/precedence.laws.spec.ts tests/resolution-engine-contract.spec.ts tests/phase5-intent-interpretation.laws.spec.tsand all tests passed (31 passed).Codex Task