Add dashboard contracts export surface and restrict deep domain imports#158
Open
danielbdyer wants to merge 1 commit into
Open
Add dashboard contracts export surface and restrict deep domain imports#158danielbdyer wants to merge 1 commit into
danielbdyer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lib/domain/observation/contracts/index.tswhich re-exports the dashboard domain surface and the dashboard-facing projection/handshake symbols, and selectively re-exportsGovernance/ResolutionModefromlib/domain/governance/workflow-types.dashboard/src/**) so they import domain types/functions fromlib/domain/observation/contractsinstead oflib/domain/observation/dashboard,lib/domain/projection/*,lib/domain/handshake/workbench, orlib/domain/governance/workflow-types.eslint.config.cjsto stop ignoring the dashboard and added ano-restricted-importsrule scoped todashboard/src/**that blocks the former deep import paths and instructs callers to use the new contracts root.Testing
rg -n "lib/domain/(observation/dashboard|projection/|handshake/workbench|governance/workflow-types)" dashboard/src dashboard/server.tswhich returned no matches.npm run lint, which reported existing repository-wide lint errors unrelated to this change (lint run failed in the workspace but the change introduced the new ESLint rule and adjusted imports as intended).npm run typecheckandnpx tsc -p dashboard/tsconfig.json, which failed due to missing generated artifacts and pre-existing typecheck diagnostics in this environment and baseline repo state, not due to the contractual import changes.Codex Task