Introduce Effect-based ACL for runtime resolution engine boundary#146
Open
danielbdyer wants to merge 1 commit into
Open
Introduce Effect-based ACL for runtime resolution engine boundary#146danielbdyer wants to merge 1 commit into
danielbdyer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
lib/applicationonly consumes Effect-based ports and typedTesseractErrorfailures instead of dynamically importing or awaiting Promises directly.TesseractErrorvariants before they cross into application code to preserve typed error semantics.Description
ResolutionEngineResolverand its port interface inlib/application/ports.tsso the application resolves engines via an Effect service instead of dynamic import.lib/application/resolution-engine.tsto require an explicit engine registry input and to returnEffect.Effect<ResolutionEngine, TesseractError>for resolution checks and capability validation (no synchronous throws).yield* ResolutionEngineResolver.resolve(...)) inlib/application/execution/interpret.tsso the application consumes only Effect-based resolution.deterministicResolutionEngineinlib/runtime/agent/index.tsthat exposesresolveStepas anEffectand normalizes runtime failures viatoTesseractErrorbefore returning to the application boundary.lib/runtime/agent/types.tsand adjusted the local runner bridging to callEffect.runPromise(...)when the runtime must execute Promise-based internals (lib/composition/local-runtime-scenario-runner.ts).lib/composition/local-services.ts,lib/composition/layers.ts) and exported the deterministic adapter for composition injection (lib/runtime/agent.ts).tests/resolution-engine-contract.spec.ts).Testing
npm test -- tests/resolution-engine-contract.spec.ts; the suite passed (3 tests passed).npm run types(build + type projection); the type build completed successfully withbuild okand generated projections.Codex Task