Modularize agent interpreter provider into focused application modules#138
Open
danielbdyer wants to merge 1 commit into
Open
Modularize agent interpreter provider into focused application modules#138danielbdyer wants to merge 1 commit into
danielbdyer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
agent-interpreter-providerimplementation into focused, testable pieces to improve separation of concerns, make provider variants pluggable, and enable incremental migration.Description
lib/application/agent-interpreter/with these modules:contract.ts,factory.ts,resilience.ts,ab-testing.ts, andproviders/{disabled,heuristic,llm-api,session}.tsto encapsulate provider wiring, retries/timeouts, A/B routing, and concrete providers.lib/application/agent-interpreter-provider.tsthat re-exportsresolveAgentInterpreterProvider,DEFAULT_AGENT_INTERPRETER_CONFIG, resilience helpers, and scoped provider constructors for incremental migration.lib/application/README.md) and regenerated the module map so the new layout is discoverable.tests/agent-interpreter-factory.spec.ts,tests/agent-interpreter-heuristic.spec.ts,tests/agent-interpreter-resilience.spec.ts, andtests/agent-interpreter-provider.integration.spec.tscovering factory precedence, fallback semantics, heuristic determinism, timeout fallback behavior, and an end-to-end LLM parsing integration.Testing
npm run mapto refresh module discoverability; the command completed successfully.npx playwright testagainst the new interpreter tests and related resilience/resource tests; the newly added tests and the related resource/resilience suites passed (all targeted tests succeeded).npm run check; typecheck failed due to pre-existing, unrelated baseline diagnostics in other tests (not introduced by this refactor).Codex Task