Refactor runtime scenario execution into explicit stage modules#127
Open
danielbdyer wants to merge 1 commit into
Open
Refactor runtime scenario execution into explicit stage modules#127danielbdyer wants to merge 1 commit into
danielbdyer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lib/runtime/scenario/types.tsto define stage input/output contracts, stage envelopes, lane metadata, and a smallScenarioContextReftype using readonly records where applicable.variantStateMatchScore,routeVariantsForScreen, andselectRouteForNavigate) intolib/runtime/scenario/route-selection.tsas pure functions.handshake.ts,interpretation.ts,step-execution.ts,recovery.ts, andreceipt-finalization.tsunderlib/runtime/scenario/and delegated implementation to them.runScenarioStepcoordinator inlib/runtime/scenario.tswhich composes the stages in order, is the sole place mutating run-localScenarioRunState, and preserves public exports (runScenarioStep,runScenarioHandshake,createScenarioRunState,stepHandshakeFromPlan).tests/runtime-scenario-stages.spec.tsto lock deterministic route-choice and recovery transition ordering using fixed fixtures.Testing
npx playwright test tests/runtime-scenario-stages.spec.tsand the two stage-level tests passed.npm run typeswhich failed due to existing type issues outside the refactor surface (e.g.lib/playwright/state-topology.ts).npx playwright test tests/runtime-agent-pipeline.spec.tswhich surfaced 3 existing pipeline-level failures (precedence/fixture and DOM-mock shape issues) that are not introduced by this refactor.Codex Task