Add exponential+jitter retry helpers and apply to transient LLM/agent/fs/observation operations#111
Open
danielbdyer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lib/application/effect.ts:exponentialJitterSchedule, a pipeableretryWithBackoff(config), andretryWithBackoffResult(effectFactory, config)which returns retry-attempt metadata (RetryResult).lib/application/translation-provider.tsforllm-apiandcopilot) withretryWithBackoffResult, gated by a transient error predicate that excludesvalidation-error, and appended retry counts into translation rationale viawithRetryMetadataRationale.lib/application/agent-interpreter-provider.ts) withretryWithBackoffResult, excludedvalidation-errorfrom retries, and propagated retry metadata into bothrationaleandobservation.detail.retryAttemptsusingaddRetryDetail.lib/infrastructure/fs/local-fs.ts(read/write/json/stat/list/ensure) by wrappingtryFileSystemeffects with a file-race predicate (checksFileSystemError.causeforENOENT/EEXIST) and a small backoff.lib/infrastructure/observation/playwright-screen-observer.ts) using a predicate that excludes validation errors and inspects the cause message for navigation/timeouts.baseDelayMs: 150, maxRecurs: 2; agent providersbaseDelayMs: 200, maxRecurs: 2; filesystem racesbaseDelayMs: 40, maxRecurs: 2; Playwright observationbaseDelayMs: 120, maxRecurs: 1.Testing
npm run build(andnpm run types) to verify compilation; the build failed due to pre-existing unrelated TypeScript issues inlib/application/benchmark.tsandlib/playwright/state-topology.tsand not due to the retry changes.Codex Task