chore(packaging-smoke): clang-format the vcpkg smoke consumer#94
Merged
Conversation
The vcpkg smoke consumer's std::printf call was manually wrapped across two lines; the current CI clang-format (bumped with the Node 24 action update in the recent CI refresh) collapses it onto a single 84-column line, so the format gate flagged it (smoke.cpp:22). The argument list fits comfortably under the 120-column soft limit. Latent since the file landed (#83): no PR touching src/** ran the C++ format job in between — the docs-only PRs since are path-filtered out — so the violation only surfaced now. Pure formatting; no behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
danielPoloWork
added
the
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reformats the vcpkg smoke consumer's
std::printfcall to satisfy the CI clang-format gate. Pure formatting — no behaviour change.Motivation
The
format / clang-format checkjob fails onci/packaging-smoke/vcpkg-consumer/src/smoke.cpp:22: the call was manually wrapped across two lines, but the current CI clang-format (bumped alongside the Node 24 action refresh) collapses it onto a single ~84-column line (well under the 120-col soft limit). The violation is latent — it landed with the file in #83, and nosrc/**-touching PR ran the C++ format job since (the docs-only PRs are path-filtered out), so it only surfaced now on asrc/-touching PR. It blocks every futuresrc/PR until fixed.Changes
ci/packaging-smoke/vcpkg-consumer/src/smoke.cpp— single-line thestd::printfcall (one line changed).Design Patterns
Verification
clang-format --style=file --dry-run --Werrorclean on the file (clang-format 22.1.5, reproduces the exact CI violation pre-fix)Documentation Impact
chorelabel,v1.1.1milestone (§6.4 / ADR-0040)Note
This unblocks the v1.1.1 release PR (#93), whose
src/-touching changes first surfaced this latent violation. After this merges, I rebaserelease/v1.1.1onmasterso its format job re-runs green.🤖 Generated with Claude Code