Add azure blob storage by l00ptr · Pull Request #65 · dalibo/cnpg-plugin-pgbackrest

l00ptr · 2026-02-03T14:08:46Z

No description provided.

l00ptr · 2026-02-03T16:13:33Z

@pchovelon & @OrioQuezac could you review this one even if it's still a draft ? I would like some feedback before adding the doc and a few more tests. I think it could be great to test it for real.

l00ptr · 2026-02-12T16:57:21Z

related to #61

This is a first step to handle more backend storage and their secret names/logic.

When converting slices of structs to environment variables, fields with the same nestedTag now share the same counter. This ensures that numbering continues between different slices instead of restating the counter. This will make possible to handle different slices for different type of repository (e.g. one slice for s3 repo and another one for Azure). E.g. with 2 different slice, we will have PGBACKREST_REPO1_S3... PGBACKREST_REPO2_S3... PGBACKREST_REPO3_AZURE...

pchovelon · 2026-02-19T09:51:29Z

+		t.Fatal("pod not ready")
+	}
+
+	b := takeBackup(ctx, t, k8sClient, NS, clusterName, "azure-backup-01", p)


We may remove `takeBackup() of this test and create a new test name CreateAndRestoreFromAzure() or something like this.
This new test will test the entire "lifecycle" Create -> Backup -> Delete -> Restore.

I won't do that until we have reduced the duration of the test.

btw, i think we can refactor and share some code between the TestCreateAndRestoreInstance for S3 and Azure tests. It should be done after improving the tests duration and probably before integrating another backend storage.

l00ptr marked this pull request as draft February 3, 2026 14:08

l00ptr force-pushed the feature/add-azure-blob-storage branch 2 times, most recently from 2686323 to 19d3449 Compare February 3, 2026 15:11

l00ptr requested review from OrioQuezac and pchovelon February 3, 2026 16:09

l00ptr mentioned this pull request Feb 5, 2026

Add custom envvar field #60

Merged

pchovelon reviewed Feb 5, 2026

View reviewed changes

Comment thread config/crd/bases/pgbackrest.dalibo.com_stanzas.yaml Outdated

pchovelon reviewed Feb 5, 2026

View reviewed changes

Comment thread config/crd/bases/pgbackrest.dalibo.com_stanzas.yaml

l00ptr force-pushed the feature/add-azure-blob-storage branch from 0373789 to 5325ffd Compare February 6, 2026 10:35

l00ptr force-pushed the feature/add-azure-blob-storage branch 2 times, most recently from 5715ce7 to 4b0991b Compare February 17, 2026 14:29

l00ptr added 7 commits February 17, 2026 16:14

Refactor GetEnvVarConfig() to split S3 logic

ce23b10

This is a first step to handle more backend storage and their secret names/logic.

Try to document a bit how we convert slice to envvar

bcec9a6

Rename SecretRef to S3SecretRef to add other storage conf

601fa0d

Move S3 repo test manifest to minio package

b450f0e

Make createSecret helper more generic

f2d7965

Make waitPod() more generic

969d423

l00ptr force-pushed the feature/add-azure-blob-storage branch from 4b0991b to 33cbb6a Compare February 17, 2026 15:28

l00ptr requested a review from pchovelon February 17, 2026 15:29

l00ptr marked this pull request as ready for review February 17, 2026 15:34