Skip to content

minor fixes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankitkhushwaha wants to merge 2 commits into
base: master
Choose a base branch
from
Open

minor fixes #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99b78e1
Fix count calculation for user copy in fops.c
ankitkhushwaha Jun 24, 2026
0705f94
Replace remove_proc_entry with remove_proc_subtree
ankitkhushwaha Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eg_03_scull_basic/fops.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ ssize_t scull_read(struct file *filp, char __user *buff, size_t count,
goto end_of_file;
}

if (count > pblock->offset)
count = pblock->offset;
if (count > pblock->offset - toffset)
count = pblock->offset - toffset;

if (copy_to_user(buff, pblock->data, count)) {
retval = -EFAULT;
Expand Down
3 changes: 1 addition & 2 deletions eg_04_proc_fs_basic/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ void __exit m_exit(void)
{
printk(KERN_WARNING MODULE_NAME " unloaded\n");

remove_proc_entry(PROC_FS_NAME, parent);
remove_proc_entry(SUB_DIR_NAME, NULL);
remove_proc_subtree(SUB_DIR_NAME, NULL);
}

module_init(m_init);
Expand Down