Updated to branch 3071 revision 1640#35
Updated to branch 3071 revision 1640#35alkemir wants to merge 4 commits intocztomczak:masterfrom alkemir:windowsUpdate
Conversation
|
The old PR for reference: #34 Added a few review comments. Otherwise looks good, thanks! |
| // loop only when last browser is closed. Otherwise | ||
| // closing a popup window will exit app while main | ||
| // window shouldn't be closed. | ||
| cef_quit_message_loop(); |
There was a problem hiding this comment.
This call should be commented out, otherwise popups will not work. In cef2go examples there are already explicit calls to cef.QuitMessageLoop(). The cefcapi project use case is very minimal.
| -------------- | ||
| 1. In cef_string.h: | ||
| this => typedef cef_string_utf16_t cef_string_t; | ||
| to => #define cef_string_t cef_string_utf16_t |
There was a problem hiding this comment.
No modification to the headers was required for compilation,
although I am not sure why it was required. My testing was
very shallow in the sense that I worried about being able to
start the browser and use it for my ends, I did not experiment with the API.
There was a problem hiding this comment.
Maybe this change in headers was required for Mac or Linux.
| 4. Run build.bat (or "build.bat noconsole" to get rid of the console | ||
| window when running the final executable) | ||
|
|
||
| 5. You might need to help your linker find libcef.dll |
There was a problem hiding this comment.
Please make only one "Getting started on Windows" section and just add a) and b) sublists for 32-bit and 64-bit. Something like:
- Install mingw:
a) If using 32-bit ...
b) If using 64-bit ...
|
The review comments did not appear until now, had to click yet another button, sorry. |
2 participants
Tested and working on Windows 32 and 64 bits.