add optional n_processes kw to backtest_many#179
Open
quant5 wants to merge 1 commit intocvxgrp:masterfrom
Open
add optional n_processes kw to backtest_many#179quant5 wants to merge 1 commit intocvxgrp:masterfrom
quant5 wants to merge 1 commit intocvxgrp:masterfrom
Conversation
Collaborator
|
Looks like there's a ton of changes because your editor ran |
Contributor
Author
|
yeah, the only actual change is here https://github.com/cvxgrp/cvxportfolio/pull/179/files#diff-ceed8a0828d51fb92ef677933274ae79b2d6f6f8082281b8fb449b6aae636892R843 your approach of min() is fine by me as well. |
Collaborator
|
I just merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution to #177
Tested on my machine running Windows and Python 3.11.5.
Original behavior (which errors for me, hence #177) is retained if parameter is not supplied.
@enzbus It's up to you whether to keep
multiprocess. (currently, it's installed as a dependency.)I hope the formatting changes are ok - my formatter (
black) automatically does those.