updates to makefile & ci configuration#115
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9107693. Configure here.
| if ! pip uninstall customerio; then echo "customerio not installed, installing it for the first time" ; fi | ||
| pip install dist/* | ||
| python -i -c "from customerio import *" | ||
| $(PYTHON) -i -c "from customerio import *" |
There was a problem hiding this comment.
Incomplete migration to PYTHON variable in upload target
Low Severity
The upload target still uses a hardcoded python on line 20 (python setup.py register) instead of $(PYTHON). Every other target was migrated to $(PYTHON), which defaults to python3. This inconsistency means the upload target may invoke a different Python interpreter (or fail entirely on systems where bare python is unavailable).
Reviewed by Cursor Bugbot for commit 9107693. Configure here.
| $(PYTHON) -i -c "from customerio import *" | ||
|
|
||
| upload: | ||
| python setup.py register |
There was a problem hiding this comment.
cursor bot above seems to be correct. This one should also be updated I think.
2 participants
Ensure that our workflows run in the proper context & clean up the makefile to explicitly use
python3Note
Low Risk
Low risk: CI trigger change and Makefile command normalization only; main impact is when tests run and which Python executable is used.
Overview
Expands the GitHub Actions workflow triggers to run on
pull_requestand manualworkflow_dispatchevents (in addition topush).Updates the
Makefileto use a configurablePYTHONvariable (defaulting topython3) for build, install, clean, dev, and test commands to avoid relying onpythonbeing present.Reviewed by Cursor Bugbot for commit 9107693. Bugbot is set up for automated code reviews on this repo. Configure here.