Ensure POST methods get retried.#101
Open
skion wants to merge 2 commits intocustomerio:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #76 (comment) it appears that retries are, although advertised, completely broken at the moment.
This fix should ensure that HTTP POST methods use the retry configuration as well, which in turn makes
send_email()be retried.Note
Medium Risk
Changes HTTP retry behavior to include POST requests, which can increase duplicate writes/emails if upstream endpoints are not idempotent. Scope is small and isolated to session retry configuration.
Overview
Updates the HTTP session retry configuration in
client_base.pyto retry all HTTP methods by settingRetry.allowed_methods=None, ensuring POST-based calls (e.g., email sends) respect the configured retry/backoff behavior.Reviewed by Cursor Bugbot for commit 2543a71. Bugbot is set up for automated code reviews on this repo. Configure here.