Skip to content

Add new webhook handler annotation.#852

Open
JayNewstrom wants to merge 1 commit into
custom-components:masterfrom
JayNewstrom:webhook-handler-pr
Open

Add new webhook handler annotation.#852
JayNewstrom wants to merge 1 commit into
custom-components:masterfrom
JayNewstrom:webhook-handler-pr

Conversation

@JayNewstrom

Copy link
Copy Markdown
Contributor

This is the follow up to #843

@webhook_handler waits for the function to return, and uses it's return value as the HTTP response.

After investigation, home assistant already validates unique webhook_id, so I removed that behavior form the original PR.

@dmamelin

Copy link
Copy Markdown
Contributor

Thanks for the work on this. I took a closer look at the patch and I think the feature makes sense, but I am not fully comfortable with the current architecture.

I am working on an alternative implementation based on the same idea, but with a smaller scope and closer integration with the existing decorator flow. It is possible that I will end up with a similar result, but I need a few more days to check this properly.

I will share it here once it is ready, so we can compare both approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants