Skip to content

Disallow clear-text HTTP protocol in ApiSession #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amrabed merged 1 commit into from
Aug 23, 2026
Merged

Disallow clear-text HTTP protocol in ApiSession #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion templates/eventbridge/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def __init__(
pool_connections=pool_connections,
pool_maxsize=pool_maxsize,
)
self._session.mount("http://", adapter)
self._session.mount("https://", adapter)

def get(self, url: str, **kwargs: Any) -> Response:
Expand Down
8 changes: 4 additions & 4 deletions tests/eventbridge/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@ def test_api_session_get_uses_timeout(mocker: MockerFixture) -> None:
session_instance.get.return_value = mock_response

api_session = ApiSession(timeout=15)
response = api_session.get("http://example.com/api")
response = api_session.get("https://example.com/api")

assert response == mock_response
session_instance.get.assert_called_once_with("http://example.com/api", timeout=15)
session_instance.get.assert_called_once_with("https://example.com/api", timeout=15)


def test_api_session_get_overrides_timeout(mocker: MockerFixture) -> None:
session_mock = mocker.patch("templates.eventbridge.session.Session")
session_instance = session_mock.return_value

api_session = ApiSession(timeout=10)
api_session.get("http://example.com/api", timeout=5)
api_session.get("https://example.com/api", timeout=5)

session_instance.get.assert_called_once_with("http://example.com/api", timeout=5)
session_instance.get.assert_called_once_with("https://example.com/api", timeout=5)


if __name__ == "__main__":
Expand Down