-
Notifications
You must be signed in to change notification settings - Fork 1
Blog page improvements #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 12 commits
2fcbe0c
90ddbd0
d257143
1ae770c
ae1df66
a31e361
72140d4
eae44f5
40dfdac
09116e3
0368d37
9b6e9cf
4add639
b82006d
4560048
fc1584a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,130 @@ | ||||||||||
| import React from 'react' | ||||||||||
| import { Link } from 'gatsby' | ||||||||||
| import styled from 'styled-components' | ||||||||||
| import FeatureImage from 'images/default-feature-image.jpg' | ||||||||||
| import ProfileIcon from 'images/DefaultProfileIcon.png' | ||||||||||
| import { formatDate } from './helpers' | ||||||||||
|
|
||||||||||
| const Card = styled.div` | ||||||||||
| margin: 15px; | ||||||||||
| position: relative; | ||||||||||
| display: flex; | ||||||||||
| flex-direction: column; | ||||||||||
| min-width: 0; | ||||||||||
| word-wrap: break-word; | ||||||||||
| background-color: var(--white); | ||||||||||
| background-clip: border-box; | ||||||||||
| border-radius: 0.25rem; | ||||||||||
|
|
||||||||||
| border: 2px solid #bfbfbf; | ||||||||||
| border-radius: var(--border-radius); | ||||||||||
| ` | ||||||||||
|
|
||||||||||
| const CardBody = styled.div` | ||||||||||
| flex: 1 1 auto; | ||||||||||
| min-height: 1px; | ||||||||||
| padding: 1.25rem; | ||||||||||
| ` | ||||||||||
|
|
||||||||||
| const CardImgTop = styled.img` | ||||||||||
| width: 100%; | ||||||||||
| border-top-left-radius: calc(0.25rem - 1px); | ||||||||||
| border-top-right-radius: calc(0.25rem - 1px); | ||||||||||
| ` | ||||||||||
|
|
||||||||||
| const Tag = styled.span` | ||||||||||
| color: var(--purple2); | ||||||||||
| ` | ||||||||||
|
|
||||||||||
| const Small = styled.div` | ||||||||||
| font-size: 62.5%; | ||||||||||
| ` | ||||||||||
|
|
||||||||||
| type BlogCardProps = { | ||||||||||
| title: string | ||||||||||
| reading_time: number | ||||||||||
| published_at: Date | ||||||||||
| excerpt: string | ||||||||||
| feature_image: string | ||||||||||
| slug: String | ||||||||||
| tags: Array<any> | ||||||||||
| primary_author_name: String | ||||||||||
| authors: Array<any> | ||||||||||
|
Comment on lines
+50
to
+52
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you also specify interfaces for Tags and Authors? (and any other interfaces that might be required). |
||||||||||
| } | ||||||||||
|
|
||||||||||
| const BlogCard = ({ | ||||||||||
| title, | ||||||||||
| reading_time, | ||||||||||
| published_at, | ||||||||||
| excerpt, | ||||||||||
| feature_image, | ||||||||||
| slug, | ||||||||||
| tags, | ||||||||||
| authors, | ||||||||||
| primary_author_name | ||||||||||
| }: BlogCardProps) => { | ||||||||||
| return ( | ||||||||||
| <Card className='mb-2'> | ||||||||||
| <Link to={'/blog/' + slug}> | ||||||||||
| <CardImgTop | ||||||||||
| src={feature_image == null ? FeatureImage : feature_image} | ||||||||||
| alt='img' | ||||||||||
| /> | ||||||||||
| <CardBody> | ||||||||||
| {tags.map((tag: any) => ( | ||||||||||
| <Tag key='tag.name'>{tag.name.toUpperCase()}</Tag> | ||||||||||
| ))} | ||||||||||
| <h2>{title}</h2> | ||||||||||
| <p>{excerpt}</p> | ||||||||||
| <Small> | ||||||||||
| <section className='post-full-byline-content'> | ||||||||||
| <ul className='author-list'> | ||||||||||
| {authors.map((author: any) => ( | ||||||||||
| <li className='author-list-item' key='author.name'> | ||||||||||
| <div className='author-card'> | ||||||||||
| <img | ||||||||||
| className='author-profile-image' | ||||||||||
| src={author.profile_image} | ||||||||||
| alt='Ghost' | ||||||||||
| /> | ||||||||||
| <div className='author-info'> | ||||||||||
| <div className='bio'> | ||||||||||
| <h2>{author.name}</h2> | ||||||||||
| </div> | ||||||||||
| </div> | ||||||||||
| </div> | ||||||||||
| <div className='author-avatar'> | ||||||||||
| <img | ||||||||||
| className='author-profile-image' | ||||||||||
| src={ | ||||||||||
| author.profile_image | ||||||||||
| ? author.profile_image | ||||||||||
| : ProfileIcon | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| } | ||||||||||
| alt='Ghost' | ||||||||||
| /> | ||||||||||
| </div> | ||||||||||
| </li> | ||||||||||
| ))} | ||||||||||
| </ul> | ||||||||||
|
|
||||||||||
| <section className='post-full-byline-meta'> | ||||||||||
| <h4 className='author-name'>{primary_author_name}</h4> | ||||||||||
| <div className='byline-meta-content'> | ||||||||||
| <time className='byline-meta-date'> | ||||||||||
| {formatDate(published_at)} | ||||||||||
| </time> | ||||||||||
| <span className='byline-reading-time'> | ||||||||||
| <span className='bull'>•</span> {reading_time} min read | ||||||||||
| </span> | ||||||||||
| </div> | ||||||||||
| </section> | ||||||||||
| </section> | ||||||||||
| </Small> | ||||||||||
| </CardBody> | ||||||||||
| </Link> | ||||||||||
| </Card> | ||||||||||
| ) | ||||||||||
| } | ||||||||||
|
|
||||||||||
| export default BlogCard | ||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use primitive types