Skip to content

Add directory hierarchy awareness to document sorting#517

Open
MuhammadTalha57 wants to merge 2 commits into
cucumber:mainfrom
MuhammadTalha57:enhancement/directory-first-search
Open

Add directory hierarchy awareness to document sorting#517
MuhammadTalha57 wants to merge 2 commits into
cucumber:mainfrom
MuhammadTalha57:enhancement/directory-first-search

Conversation

@MuhammadTalha57

Copy link
Copy Markdown

🤔 What's changed?

This PR updates the document sorting logic so nested directories are ordered before direct child files, matching how users typically expect hierarchy-aware sorting to behave in IDEs and file explorers.

⚡️ What's your motivation?

Addresses issue #492

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I’d especially appreciate feedback on the test coverage I added. I couldn’t find a more appropriate place for these tests, so I added them in the samples folder, which also appears to be how the previous implementation was covered.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant