Refactor/v11 push test case ready message earlier#1864
Open
luke-hill wants to merge 8 commits into
Open
Conversation
* Replace the 2 instances of `@test_case_by_step_id` * Add note for iVar removal * Avoid fully the use of the fake query private method by relying entirely on the repository data; * Add redudancy warnings; * Remove redundancies * Tidy up code * Revert minor change to make tests pass * Fix up naming conventions * Add notes / trace for where to look next to try triage * WIP always select the test case started message with the largest attempt counter when multiple exist * Remove all placeholders
* Add fake query constant to generate new way of calculating attempts * Switch attempts and initial test case started over to new system, commenting out old code * Cleanup of boilerplate placeholder code * Remove fake query and spec for test_case_started_by_test_case * WIP * WIP 2 * Remove duplicate method call that should be :no_op * Refactor and remove fake query step that can be a :no_op * Switch out the test_case_started_id method to use the refactored one from previous PR * For test case started events, we always need to ensure the current test case started id is newly generated and not fetched * Add note for new id generation
* WIP derive the id for final missing item - test_case_started_id when calling on_test_case_finished handler * Remove `_new` suffix * Remove private method now its no longer used * Re-order methods
…move one fake query
…th the handler calling update each and every time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This attempts to bring the test case event message earlier
This breaks a couple of feature tests regarding event ordering and NME's being generated for missing ids
Type of change
Please delete options that are not relevant.
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses