Skip to content

docs: fix broken /docs/deployment/cloud/* links#10936

Merged
keydunov merged 1 commit into
masterfrom
cursor/fix-legacy-deployment-types-links
May 22, 2026
Merged

docs: fix broken /docs/deployment/cloud/* links#10936
keydunov merged 1 commit into
masterfrom
cursor/fix-legacy-deployment-types-links

Conversation

@keydunov
Copy link
Copy Markdown
Member

Summary

A customer reported that https://docs.cube.dev/admin/deployment/deployment-types#deployment-types is broken. While investigating, I found:

  • The page itself is live and the customer-reported URL returns 200. The #deployment-types fragment in their URL doesn't match any heading on the page (section anchors are #shared, #dedicated, #multi-cluster, #switching-between-deployment-types), so the page just lands at the top instead of scrolling. Nothing in our codebase generates that exact fragment.
  • The actual broken-link problem is much bigger: the legacy paths /docs/deployment/cloud/{deployment-types,auto-suspension,limits,scalability} now 404 on the live docs, but were still used as [ref-...] link references in 12 of our own MDX files. So every "learn more about deployment types / auto-suspension / limits / scalability" link from those pages was silently 404'ing.

This PR:

  • Adds four redirects in docs-mintlify/docs.json mapping /docs/deployment/cloud/{deployment-types,auto-suspension,limits,scalability}/admin/deployment/<same>, so any external/cached/customer-saved link keeps working.
  • Rewrites internal [ref-...] references in 12 MDX files to use the canonical /admin/deployment/* paths directly, so internal links no longer route through the redirect.

Verified live status before/after of each path:

deployment-types: legacy=404 new=200
auto-suspension:  legacy=404 new=200
limits:           legacy=404 new=200
scalability:      legacy=404 new=200

Test plan

  • mintlify dev --no-open boots without compile errors.
  • mintlify broken-links reports no new broken anchors.
  • Spot-check rendered pages: pricing, auto-suspension, limits, scalability, deployment-types, environments, warm-up, performance, monitoring-integrations, semantic-layer-sync, refreshing-pre-aggregations — all [ref-...] links resolve to live pages.
  • After deploy, curl -sI https://docs.cube.dev/docs/deployment/cloud/deployment-types returns a redirect to /admin/deployment/deployment-types.

Made with Cursor

The legacy paths /docs/deployment/cloud/{deployment-types,auto-suspension,
limits,scalability} now 404 on the live docs site, but were still used as
[ref-...] references throughout the docs and from external/cached links.

- Add redirects in docs.json from the four legacy paths to their current
  /admin/deployment/* counterparts.
- Rewrite internal [ref-...] references in 12 MDX files to use the new
  canonical /admin/deployment/* paths instead of going through redirects.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 22, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview May 22, 2026, 5:02 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 22, 2026

Claude finished @keydunov's task in 1m 45s —— View job


Code Review: docs link fixes

  • Gather context and read changed files
  • Review redirect configuration in docs.json
  • Review link reference updates across MDX files
  • Check for any remaining broken references
  • Post review summary

Overall: Looks good. The PR correctly identifies the broken /docs/deployment/cloud/*/admin/deployment/* migration gap, fixes internal references in 12 files, and adds redirects for external/cached links. The changes are mechanical and correct — every updated anchor (#shared, #dedicated, #multi-cluster, #resources, #auto-scaling-of-api-instances, #sizing-cube-store-workers, #effects-on-experience) matches a real heading ID in the target file.

Findings

One missed reference in a file this PR already touches (left inline comment):

docs-mintlify/admin/monitoring/monitoring-integrations/index.mdx:370 still uses /docs/deployment/cloud/warm-up#pre-aggregation-warm-up — same broken-path pattern. Since this file is already modified in this PR, it's worth fixing here.

Additional /docs/deployment/cloud/* references outside this PR's scope — these are not the four paths targeted, but worth noting for a follow-up:

File Line Path
admin/monitoring/monitoring-integrations/index.mdx 372 /docs/deployment/cloud/deployments
admin/account-billing/pricing.mdx 336–348 /docs/deployment/cloud/custom-domains, /vpc, /support, /infrastructure
admin/deployment/infrastructure.mdx 93, 163 /docs/deployment/cloud/byoc, /vpc
admin/deployment/providers/*.mdx various /docs/deployment/cloud/deployments, /vpc/azure
docs/data-modeling/*.mdx various /docs/deployment/cloud/deployments, /continuous-deployment
admin/monitoring/audit-log.mdx 83, 85 /docs/deployment/cloud/deployments, /continuous-deployment
reference/core-data-apis/mdx-api.mdx 229 /docs/deployment/cloud/deployments

These may or may not be broken (they use different sub-paths like /deployments, /vpc, /support etc. that might still resolve). A mintlify broken-links check would confirm.

Minor nit (inline comment): Three files (scalability.mdx, semantic-layer-sync/index.mdx, refreshing-pre-aggregations.mdx) are missing a trailing newline — the \ No newline at end of file markers pre-existed but since these lines are being touched anyway, adding a final newline would be a nice cleanup.

Summary

The core fix is correct and well-scoped. The one actionable item is the missed warm-up reference on line 370 of monitoring-integrations/index.mdx. The rest of the /docs/deployment/cloud/* references in the repo use different sub-paths and can be handled in a separate pass.

@@ -340,7 +340,7 @@ Query History export.
</Note>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file still has two other /docs/deployment/cloud/* references that weren't updated:

  • Line 370: /docs/deployment/cloud/warm-up#pre-aggregation-warm-up
  • Line 372: /docs/deployment/cloud/deployments

The warm-up one is the same pattern as the four paths fixed in this PR — the page lives at /admin/deployment/warm-up now. Worth fixing here since you're already touching this file.

Suggested change
</Note>
[ref-autosuspend]: /admin/deployment/auto-suspension#effects-on-experience



[ref-limits]: /docs/deployment/cloud/limits#resources No newline at end of file
[ref-limits]: /admin/deployment/limits#resources No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing trailing newline. The diff shows No newline at end of file — this pre-existed, but since you're touching this line anyway it'd be nice to add one.

Suggested change
[ref-limits]: /admin/deployment/limits#resources
[ref-limits]: /admin/deployment/limits#resources

@keydunov keydunov merged commit b9ae182 into master May 22, 2026
16 checks passed
@keydunov keydunov deleted the cursor/fix-legacy-deployment-types-links branch May 22, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant