fix(cubestore): add table name to "Import downloaded" log line#10757
Open
ReptilianBrain wants to merge 3 commits intocube-js:masterfrom
Open
fix(cubestore): add table name to "Import downloaded" log line#10757ReptilianBrain wants to merge 3 commits intocube-js:masterfrom
ReptilianBrain wants to merge 3 commits intocube-js:masterfrom
Conversation
When CUBEJS_DB_EXPORT_BUCKET is configured, Redshift UNLOADs to S3 signed URLs whose paths contain only a content hash. This change passes table_name from do_import() into resolve_location() and includes it in both Import downloaded log lines, mimicking the observability that is available through temp:// paths.
github-actions
Bot
added
cube store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CUBEJS_DB_EXPORT_BUCKET is configured, Redshift UNLOADs to S3
signed URLs whose paths contain only a content hash.
This change passes table_name from do_import() into resolve_location() and
includes it in both Import downloaded log lines, mimicking the
observability that is available through temp:// paths.
Check List