feat(api-gateway): Always include usedPreAggregations in Load Request Success logs#10310
Open
Emile-Filteau wants to merge 1 commit intocube-js:masterfrom
Open
Conversation
github-actions
bot
added
javascript
Contributor
Author
|
@igorlukanin Would it be possible to get some eyes on this? It would help our team greatly to be able to see which queries uses pre-aggregations and which one doesn't from our Cube Core production logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Closes #10309
Description of Changes Made (if issue reference is not provided)
Moving the
usedPreAggregationsentry of the response object in the api gateway to always be present, instead of being filtered on "devMode" and playground request only.This allows the
Load Request Successlog to properly includequeriesWithPreAggregations. This will help with using cubejs logs when self hosting to see which requests goes through a pre-aggregation or not.