feat(schema-compiler): support string, time, and boolean measure types in pre-aggregations#10290
Open
zubairov wants to merge 9 commits intocube-js:masterfrom
Open
feat(schema-compiler): support string, time, and boolean measure types in pre-aggregations#10290zubairov wants to merge 9 commits intocube-js:masterfrom
zubairov wants to merge 9 commits intocube-js:masterfrom
Conversation
…s in pre-aggregations - Add support for string, time, and boolean measure types in pre-aggregations - Use MAX aggregation function for non-numeric measures instead of SUM - Modify aggregateOnGroupedColumn in BaseQuery.js to handle string/time/boolean types - Update aggregationsColumns in PreAggregations.ts with string/time/boolean mappings - Add comprehensive unit tests for string, time, and boolean measure pre-aggregations Fixes cube-js#7896
github-actions
bot
added
javascript
Co-authored-by: zubairov <56208+zubairov@users.noreply.github.com>
…c-types Fix pre-aggregation test to use correct PostgresQuery API
pnedelko
reviewed
Jan 8, 2026
packages/cubejs-schema-compiler/test/unit/pre-agg-string-time-measures.test.ts
Outdated
Show resolved
Hide resolved
…measures.test.ts Co-authored-by: Pavel Nedelko <pnedelko@gmail.com>
Author
|
@paveltiunov @igorlukanin guys any updates here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #7896 by adding support for string, time, and boolean measure types in pre-aggregations.
Problem
When using pre-aggregations with calculated measures of non-numeric types (string, time, or boolean), the pre-aggregation table is created correctly, but the SELECT clause incorrectly uses the SUM function on these non-numeric fields, which is invalid SQL.
Solution
Changes
Testing
Added 5 comprehensive unit tests:
Backward Compatibility
✓ Fully backward compatible
✓ No breaking changes
✓ Existing numeric measure types continue to work as before
Fixes #7896