Similar posts: 4 closest by embedding, fallbacks when empty or no embeddings#170
Open
Similar posts: 4 closest by embedding, fallbacks when empty or no embeddings#170
Conversation
…edding Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changed the similar listings endpoint so now that it only returns up to 4 similar listings (exactly what the frontend displays) for each post.
There's fallbacks in place for when we can't find similar posts
Changes Made
Reduced number of listings returned and added fallbacks
Test Coverage
Tested locally
Next Steps (delete if not applicable)
Change frontend to cache similar postings to reduce # of api calls...