-
Notifications
You must be signed in to change notification settings - Fork 0
Add ecosystem gym UI and refactored common interface for ecosystem models #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
04jono
wants to merge
11
commits into
main
Choose a base branch
from
jonathan/gyms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
45b5974
Gyms cards without capacity or hours
04jono 8b4acfc
Unify operating hours for gyms
04jono d775102
Merge remote-tracking branch 'origin' into jonathan/gyms
04jono ac1edc7
Clean up docs
04jono 0d897f4
Add circular indicator from uplift
04jono e2238c8
capacity on main screen
04jono bea2272
Merge remote-tracking branch 'origin' into jonathan/gyms
04jono 3277a8c
Fix padding
04jono 8449b76
Adjust capacity indicator
04jono 0f9d903
Fix operating hours bug
04jono f216f08
Remove redundant operating hours rotation
04jono File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 0 additions & 6 deletions
6
app/src/main/java/com/cornellappdev/transit/models/ecosystem/DetailedEcosystemPlace.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
app/src/main/java/com/cornellappdev/transit/models/ecosystem/EcosystemPlace.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.cornellappdev.transit.models.ecosystem | ||
|
|
||
| import com.cornellappdev.transit.models.Place | ||
|
|
||
| /** | ||
| * Specific places such as eateries or gyms | ||
| */ | ||
| interface EcosystemPlace { | ||
|
|
||
| /** | ||
| * Convert from a specific ecosystem place to the generic [Place] class | ||
| */ | ||
| fun toPlace(): Place | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * Interface for working with places in ecosystem with special details, i.e. hours or capacity | ||
| */ | ||
| sealed interface DetailedEcosystemPlace: EcosystemPlace { | ||
|
|
||
| /** | ||
| * @Return a list of associated dayOfWeek and hours pairs in [DayOperatingHours] representing | ||
| * each day of the week and the corresponding times that an eatery is open. The list is sorted | ||
| * by day with the custom dayOrder (Sunday first). | ||
| */ | ||
| fun operatingHours(): List<DayOperatingHours> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty similar to the above DetailedPlaceHeaderSection composable in implementation, is there any way we can consolidate them or share ui code between them?