Implement Filtering UI by RyanCheung555 · Pull Request #120 · cuappdev/ithaca-transit-compose

RyanCheung555 · 2026-02-18T22:53:35Z

Overview

Added the UI for a filter button and filtering actions

Changes Made

Added a clickable filter button that pulls up an interactive bottom sheet to select filters
When filters are selected, their respective labels appear next to the filter button for clarity

Test Coverage

Tested on Medium Phone emulator
Run on ecosystem build
Simple interaction tests with filter button and verifying appearance

Next Steps (delete if not applicable)

Add filter functionality

Screenshots (delete if not applicable)

The last button press was 'cancel' (e.g. do nothing)

Filter UI Screen Recording

filter_ui_demo.webm

…ed basic filter button component

…d added TODOs

…clicked

…t for readability

… of their components

…icking experience

…is provided between cards

…nality

Copilot

Pull request overview

This pull request implements the UI components for a filtering feature in the favorites section. The PR adds interactive filter buttons and bottom sheets that allow users to select location type filters (Gyms, Eateries, Libraries, Printers, Other), with selected filters displayed as removable tags. The actual filtering functionality is intentionally deferred to a future PR, as stated in the "Next Steps" section.

Changes:

Added UI components for filter button, filter row with removable tags, and modal bottom sheet for filter selection
Introduced filter state management in HomeViewModel to track selected and applied filters
Created new drawable resources for filter icons representing different location types

Reviewed changes

Copilot reviewed 18 out of 24 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
app/src/main/res/drawable/*.xml	New vector drawable icons for different location type filters (printer, other, library, gym, eatery, and main filter icon)
app/src/main/java/com/cornellappdev/transit/ui/viewmodels/FavoritesFilterSheetState.kt	New enum class defining the available filter types with their icons and labels
app/src/main/java/com/cornellappdev/transit/ui/viewmodels/FilterState.kt	Added trailing comma to last enum entry for consistency
app/src/main/java/com/cornellappdev/transit/ui/viewmodels/HomeViewModel.kt	Added state management for filter sheet visibility and selected/applied filters
app/src/main/java/com/cornellappdev/transit/ui/theme/Color.kt	Added MutedTransitBlue color for active filter background
app/src/main/java/com/cornellappdev/transit/ui/screens/HomeScreen.kt	Integrated filter sheet state into the home screen
app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterRow.kt	New component displaying the filter button and selected filter tags in a flow row
app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterButton.kt	New button component that triggers the filter bottom sheet
app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterSheetItem.kt	New component for individual filter options in the bottom sheet grid
app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt	Modal bottom sheet component displaying filter options with cancel/apply actions
app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt	Integrated filter UI into the favorites view with conditional rendering
app/src/main/java/com/cornellappdev/transit/ui/components/home/RoundedImagePlaceCard.kt	Removed horizontal and vertical padding to allow for spacing in parent component
app/src/main/java/com/cornellappdev/transit/ui/components/home/AddFavoritesButton.kt	Added vertical content padding parameter
.DS_Store, app/.DS_Store, app/src/.DS_Store, app/src/main/.DS_Store, app/src/main/res/.DS_Store, app/src/main/res/drawable/.DS_Store	macOS system files that should not be committed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

Copilot · 2026-02-18T22:58:57Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterRow.kt

+        onRemoveFilter = {}
+    )
+
+


There are two blank lines at the end of this preview function. This is inconsistent with the codebase style, where preview functions typically have only one blank line after the closing brace (see line 98 or other preview functions in the codebase).

Suggested change

Copilot · 2026-02-18T22:58:57Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterSheetItem.kt

+
+}


There is an extra blank line after the closing brace. This is inconsistent with the codebase style where preview functions typically have only one blank line after the closing brace (see other preview functions in the codebase).

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

Copilot · 2026-02-18T22:58:57Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterSheetItem.kt

+                color = if(isActive) TransitBlue else MetadataGray,
+                shape = RoundedCornerShape(8.dp)
+            )
+            .background(
+                color = if(isActive) MutedTransitBlue
+                    else Color.Transparent,
+                shape = RoundedCornerShape(8.dp)
+            )
+            .clickable(onClick = itemOnClick)
+            .padding(vertical = 16.dp),
+        horizontalAlignment = Alignment.CenterHorizontally
+    ) {
+        Icon(
+            painterResource(id = iconId),
+            contentDescription = label,
+            modifier = Modifier
+                .size(34.dp),
+            tint = if(isActive) TransitBlue else Color.Unspecified
+        )
+
+        Spacer(modifier = Modifier.height(8.dp))
+
+        Text(
+            label,
+            color = if(isActive) TransitBlue else MetadataGray,


Missing space after 'if' keyword. The codebase consistently uses 'if (' with a space (see examples in BottomSheetFilterItem.kt:41, FilterRow.kt:48, EcosystemBottomSheetContent.kt:116). Please change 'if(isActive)' to 'if (isActive)' for consistency with the codebase style.

Copilot · 2026-02-18T22:58:58Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterSheetItem.kt

+
+@Preview(showBackground = true)
+@Composable
+private fun InactiveFavoritesFilterSheetItemInactive() {


The preview function name 'InactiveFavoritesFilterSheetItemInactive' is inconsistent with the preview naming convention used elsewhere in the codebase. Based on other preview functions like 'PreviewBottomSheetFilterItem' and 'InactivePreviewBottomSheetFilterItem' (from BottomSheetFilterItem.kt), the name should be 'InactivePreviewFavoritesFilterSheetItem' or 'PreviewFavoritesFilterSheetItemInactive' to maintain consistency.

Suggested change

private fun InactiveFavoritesFilterSheetItemInactive() {

private fun PreviewFavoritesFilterSheetItemInactive() {

Copilot · 2026-02-18T22:58:58Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterSheetItem.kt

+
+}


There is an extra blank line after the closing brace. This is inconsistent with the codebase style where preview functions typically have only one blank line after the closing brace (see other preview functions in the codebase).

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

Copilot · 2026-02-18T22:58:58Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterButton.kt

+
+    ) {


Extra blank line in function signature. There's an unnecessary blank line between the parameter list and the closing brace. Remove line 28 for cleaner code formatting.

Suggested change

) {

) {

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

AndrewCheung360 · 2026-02-19T22:26:52Z

Remove the .DS_Store files

app/src/main/java/com/cornellappdev/transit/ui/components/home/AddFavoritesButton.kt

AndrewCheung360 · 2026-02-22T18:50:54Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

+    showFilterSheet: Boolean,
+    onFilterSheetShow: () -> Unit,
    onAddFavoritesClick: () -> Unit,
+    homeViewModel: HomeViewModel = hiltViewModel(),


We shouldn't be passing view models to composables, they should ideally only be used on the screen composable. You should just add whatever fields or functions you need from the vm to this composable as parameters

If there are too many parameters, you can consider grouping some together into a data class

AndrewCheung360 · 2026-02-22T18:51:21Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

        )
    }
+
+    val selectedFilters by homeViewModel.selectedFavoritesFilters.collectAsStateWithLifecycle()


see above comment, but this should be passed in instead of using the home vm here

AndrewCheung360 · 2026-02-22T18:51:48Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

+    if (showFilterSheet) {
+        ModalBottomSheet(
+            onDismissRequest = {
+                homeViewModel.cancelFavoritesFilters()


see above for all functions you are using from home view model

AndrewCheung360 · 2026-02-22T18:53:39Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

-        when (currentFilter) {
-            FilterState.FAVORITES -> {
-                favoriteList(favorites, navigateToPlace, onAddFavoritesClick)
+    val appliedFilters by homeViewModel.appliedFavoritesFilters.collectAsStateWithLifecycle()


same as above

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

AndrewCheung360 · 2026-02-22T20:35:38Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt

+                )
            }
+        }
+        val isFilterBarHidden = currentFilter == FilterState.FAVORITES && appliedFilters.isEmpty()


Nit: might be worth abstracting to vm or using some sort of derived value from the data class

AndrewCheung360 · 2026-02-22T20:37:16Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

+import androidx.compose.foundation.lazy.grid.LazyVerticalGrid
+import androidx.compose.foundation.lazy.grid.items
+import androidx.compose.foundation.shape.RoundedCornerShape
+import androidx.compose.material.Button


Should be using material3

check other imports below for same reason

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

AndrewCheung360 · 2026-02-22T20:39:38Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

+                .padding(horizontal = 24.dp, vertical = 24.dp),
+            verticalAlignment = Alignment.CenterVertically
+        ) {
+            Text(


Nit: If you guys set up a typography system based on figma design system, might be easier to just use the typography style instead of manually including all the font styling all the time

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

AndrewCheung360 · 2026-02-22T20:43:58Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

+    text: String,
+    modifier : Modifier = Modifier
+){
+    val isCancel = text == "Cancel"


I think there should be a better way than this? Maybe just have an optional parameter?

AndrewCheung360 · 2026-02-22T20:44:40Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt

+}
+
+@Composable
+private fun FooterButton(


Nit: These button components can usually be boiled down to having one central reusable button component for the app that takes in various parameters when needed to customize it

AndrewCheung360 · 2026-02-22T21:40:27Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterSheetItem.kt

+
+}
+
+@Preview(showBackground = true)


Nit: you can use preview parameters instead of making 2 separate previews

AndrewCheung360 · 2026-02-22T21:44:47Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterRow.kt

+    modifier: Modifier = Modifier
+) {
+    FlowRow(
+        modifier = modifier,


Add animateContentSize for more smooth animation when adding or removing filters

AndrewCheung360 · 2026-02-22T21:48:25Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterButton.kt

+            containerColor = Color.Transparent,
+            contentColor = SecondaryText
+        ),
+        contentPadding = PaddingValues(horizontal = 8.dp, vertical = 0.dp)


I don't think vertical 0.dp does anything but test it out to be safe

AndrewCheung360 · 2026-02-22T21:51:12Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterRow.kt

+                FilterLabel(
+                    text = filter.label,
+                    onRemove = { onRemoveFilter(filter) },
+                    modifier = Modifier.align(Alignment.CenterVertically)


This modifier might not be necessary. Pretty sure there is a way to do center vertically in the vertical arrangement + spaced by at the same time

AndrewCheung360 · 2026-02-22T21:51:35Z

app/src/main/java/com/cornellappdev/transit/ui/components/home/FilterRow.kt

+    ) {
+        FilterButton(
+            onFilterClick = onFilterClick,
+            modifier = Modifier.align(Alignment.CenterVertically)


Not sure if necessary, see below comment

AndrewCheung360 · 2026-02-22T21:52:39Z

app/src/main/java/com/cornellappdev/transit/ui/screens/HomeScreen.kt

    var searchActive by remember { mutableStateOf(false) }

+    // Favorite filter bottom sheet state
+    val showFilterSheet by homeViewModel.showFilterSheet.collectAsState()


should be using collectAsStateWithLifecycle ideally

AndrewCheung360 · 2026-02-22T21:56:51Z

app/src/main/java/com/cornellappdev/transit/ui/viewmodels/HomeViewModel.kt

+    }
+
+    fun removeAppliedFilter(filter: FavoritesFilterSheetState) {
+        _selectedFavoritesFilters.value = _selectedFavoritesFilters.value - filter


Nit: you can use -=

AndrewCheung360 · 2026-02-22T21:57:47Z

app/src/main/java/com/cornellappdev/transit/ui/viewmodels/HomeViewModel.kt

@@ -90,6 +90,13 @@



Nit: could be worth separating filter logic into separate vm or file for better separation and organization

AndrewCheung360 · 2026-02-22T21:59:25Z

app/src/main/java/com/cornellappdev/transit/ui/viewmodels/HomeViewModel.kt

        _showAddFavoritesSheet.value = show
    }

+    val favoritesFilterList = listOf(


For constants like these, we can create some sort of specific constants file somewhere else instead of using home vm to store it

AndrewCheung360 · 2026-02-22T22:00:05Z

app/src/main/java/com/cornellappdev/transit/ui/viewmodels/HomeViewModel.kt

     */
    val defaultIthaca = LatLng(42.44, -76.50)

    val filterList = listOf(


Same thing as below comment about constants in separate file

RyanCheung555 and others added 23 commits February 7, 2026 02:09

downloaded filter icon, created divider when viewing favorites, creat…

56670b0

…ed basic filter button component

Updated filter icon file

db041a6

Added vector asset for filter icon

e95dbca

Added a call to filter button from ecosystem bottom sheet content, an…

892ac11

…d added TODOs

feat: create simple vers of filter bottom sheet w/ header/footer

074e75b

refactor: let viewmodel handle state for fav filter button/sheet

a71f3af

fix: use correct color for filter button text

3b3d8d1

feat: Create grid for filters in favorite filter sheet

1df94ec

Add border and background changing functionality when filter item is …

c90d948

…clicked

fix: rename FilterSheetState to FavoritesFilterSheetState for clarity

74a29ad

fix: rename other FilterBottomSheet components to FavoritesFilterShee…

ece224d

…t for readability

refactor: rename FavoritesFilterBottomSheet files to reflect the name…

8845964

… of their components

feat: add correct icons for filter bottom sheet

57ed6cd

feat: create reusable color for highlighted backgrounds

b1c41ec

fix: use icon instead of image + fix formatting issues to fit designs

4ac9ec8

fix: move clickable modifier in front of padding for more accurate cl…

b36124e

…icking experience

chore: remove unused imports

04f9007

fix: adjust button spacing and sync with main

46a5370

fix: change padding values to match design, and refactor how padding …

903c2e1

…is provided between cards

fix: move filter logic to HomeViewModel and add filter labels

072e774

feat: make filter labels on par with design and include close functio…

7d807bb

…nality

fix: make formatting closer to design

b182f14

chore: fix formatting and naming, as well as remove unused imports

2259ebd

RyanCheung555 requested review from AndrewCheung360 and Copilot February 18, 2026 22:53

Copilot started reviewing on behalf of RyanCheung555 February 18, 2026 22:54 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

fix: add spacer for separation between filter labels and column of cards

6924f02

AndrewCheung360 reviewed Feb 22, 2026

View reviewed changes

app/src/main/java/com/cornellappdev/transit/ui/components/home/AddFavoritesButton.kt Outdated Show resolved Hide resolved

AndrewCheung360 reviewed Feb 22, 2026

View reviewed changes

app/src/main/java/com/cornellappdev/transit/ui/components/home/EcosystemBottomSheetContent.kt Outdated Show resolved Hide resolved

AndrewCheung360 reviewed Feb 22, 2026

View reviewed changes

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt Show resolved Hide resolved

AndrewCheung360 reviewed Feb 22, 2026

View reviewed changes

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt Show resolved Hide resolved

AndrewCheung360 reviewed Feb 22, 2026

View reviewed changes

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt Outdated Show resolved Hide resolved

AndrewCheung360 reviewed Feb 22, 2026

View reviewed changes

app/src/main/java/com/cornellappdev/transit/ui/components/home/FavoritesFilterBottomSheet.kt Outdated Show resolved Hide resolved

AndrewCheung360 reviewed Feb 22, 2026

View reviewed changes

AndrewCheung360 requested changes Feb 22, 2026

View reviewed changes

RyanCheung555 added 4 commits February 22, 2026 18:53

fix: adjust padding value for list of favorites

c9a6192

fix: use correct color for horizontal divider

727a0e0

chore: remove unused line and import

cb090b2

fix: add preview function and adjust how padding is handled

6962eaf

	private fun InactiveFavoritesFilterSheetItemInactive() {
	private fun PreviewFavoritesFilterSheetItemInactive() {


		}

		@Preview(showBackground = true)

Comments

Conversation

RyanCheung555 commented Feb 18, 2026

Overview

Changes Made

Test Coverage

Next Steps (delete if not applicable)

Screenshots (delete if not applicable)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AndrewCheung360 commented Feb 19, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AndrewCheung360 Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewCheung360 Feb 22, 2026 •

edited

Loading