[fix] stabilize flaky Tcl CI test cases#436
Open
warrick1016 wants to merge 2 commits into
Open
Conversation
Squash flaky1~flaky31: stabilize unstable CI Tcl test cases. Covers retry logic, wait_for_condition timeouts, replication sync, RDB/AOF persistence, client eviction, shutdown, slowlog, swap integration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> [fix] remove flaky Wr(MB/s) rate assertion in compact_range test Wr(MB/s) is a rolling-interval rate metric — returns 0.0 after compaction completes and server goes idle. Replace with cumulative Comp(sec) > 0.0 which already exists on the next line. Avoids false failures on slow/ASAN builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> [fix] restore LIFO order assertion in slowlog test for non-swap mode lsort-based comparison only under $::swap where swap I/O timing can disturb entry order; standard builds restore original index-based assertions that validate LIFO ordering semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash flaky1~flaky31: stabilize unstable CI Tcl test cases. Covers retry logic, wait_for_condition timeouts, replication sync, RDB/AOF persistence, client eviction, shutdown, slowlog, swap integration.
[fix] remove flaky Wr(MB/s) rate assertion in compact_range test
Wr(MB/s) is a rolling-interval rate metric — returns 0.0 after compaction completes and server goes idle. Replace with cumulative Comp(sec) > 0.0 which already exists on the next line. Avoids false failures on slow/ASAN builds.
[fix] restore LIFO order assertion in slowlog test for non-swap mode
lsort-based comparison only under $::swap where swap I/O timing can disturb entry order; standard builds restore original index-based assertions that validate LIFO ordering semantics.