Delete and append instead of setline, to prevent bug when result line…#12
Open
iovar wants to merge 3 commits intocsscomb:masterfrom
Open
Delete and append instead of setline, to prevent bug when result line…#12iovar wants to merge 3 commits intocsscomb:masterfrom
iovar wants to merge 3 commits intocsscomb:masterfrom
Conversation
…s are less than the initial
|
u may want to use "delete_" instead of "delete", prevent to cut the tempfile in clipboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the lines after combing are fewer than before combing, the extra lines remain in the buffer and mess up the file. e.g.
will result to this:
By deleting the lines and then appending, this doesn't happen and the result is correct.