Restrict the default key binding to when a CSS syntax is active#33
Open
TrevorBurnham wants to merge 1 commit intocsscomb:masterfrom
TrevorBurnham:restrict-default-key-binding-to-css-syntax
Open
Restrict the default key binding to when a CSS syntax is active#33TrevorBurnham wants to merge 1 commit intocsscomb:masterfrom TrevorBurnham:restrict-default-key-binding-to-css-syntax
TrevorBurnham wants to merge 1 commit intocsscomb:masterfrom
TrevorBurnham:restrict-default-key-binding-to-css-syntax
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended as a complement to #32, which I think is a very solid change.
Currently, the CSScomb command is a no-op unless an appropriate syntax is detected. This PR makes the key binding do the same syntax-checking that the CSScomb command does in #32. This prevents the command from interfering with other plugins that may use the same keyboard shortcut in other contexts. For example, I use SublimeGit, which uses Ctrl+Shift+C for its "Git Commit Amend" command, but only in its SublimeGit Status context.