#280 - Move asset files and reports into a folder#312
Merged
craigfowler merged 24 commits intomasterfrom Mar 7, 2026
Merged
Conversation
Common illegal characters for operating systems.
This will help when handling the file later.
This is some work I did over a week ago, I need to take stock of this, because I lost track of what's done and what is left.
It seems that SonarScanner is breaking the build by changing the way it works. Thus, the `.cs.pp` file inside the MimeTypes NuGet package isn't being built.
I had attempted to fix the NuGet package reference for the MimeTypes package, but I can't make this work in conjunction with SonarScanner, so I'm going to abort it and change method. This commit reverts the following: * 43c6b73 * 95f2659 * c28b86a * 308e60a What I'll do after this is to just include the .cs file manually and not use NuGet for it.
The reason I changed the behaviour is because the error was bringing down the whole page when I was testing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve #280