add runtime bounds checking and improve array method error diagnostics#183
Merged
add runtime bounds checking and improve array method error diagnostics#183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throw new Error()calls toctx.emitError()across all array method codegen — users now get proper compiler errors with file/line info instead of ugly stack traces when they misuse array methods (wrong arg count, wrong arg type for filter/map/reduce/find/some/every/etc.)__cs_bounds_check,__cs_null_check) in LLVM declarationsNotes
arr[0]patterns on empty arrays that need fixing first (tracked separately)Test plan
array-bounds-check.tsverifies OOB access exits with code 1🤖 Generated with Claude Code