Conversation
06c747d to
933ff37
Compare
…every, includes, shift Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
933ff37 to
5595b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setVariableTypecalls for return values in 10 array method codegen functionsfilterandmapwere missing type tracking (%Array*), while their string counterparts had itsome,every,includes(both numeric and string variants) returneddoublefrom rawsitofpwithout type trackingshiftreturneddoublefrom rawphiwithout type trackingreduceused rawemitfor load instead ofemitLoad(which auto-tracks type)These gaps mean downstream code can't determine the return type of these array operations, which can cause wrong IR when the result is used in assignments, parameter passing, or chained operations.
Test plan
🤖 Generated with Claude Code