Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit()override inLLVMGenerator— any instruction containing@GC_setsusesGC = 1without manual tagging at 250+ call sitesgenerateParts()scansirPartsandglobalStringsbeforegenerateMain()to catch GC references from string-builder helpers (ir +=patterns) that bypassemit()GC_init()behindusesGCingenerateMain()— only called when program uses heap allocationgc:flag ingetLLVMDeclarations()—declare void @GC_init(),declare noalias i8* @GC_malloc(i64)etc. only emitted when used-lgcbehindusesGCin bothcompiler.tsandnative-compiler-lib.tsjson.ts::generateJsonParser()for json parser functions that build IR vialines.push()rather thanctx.emit()Status
The infrastructure is complete and correct. For programs that use path/fs/string helpers (which are unconditionally emitted and reference
@GC_malloc),usesGCis still always true — these helpers need to be gated in a follow-up PR before "hello world" can skip GC entirely. The linker/IR gate correctly responds tousesGCand will automatically skip GC once those helpers are gated.Test plan