fix: Bool|Nil cast for sync= on Crystal 1.20.1#9
Open
ozgurulukir wants to merge 1 commit into
Open
Conversation
returns . Direct assignment to with the nilable union fails on Crystal 1.20.1 at the type-checker level (comparable to issue crystal-term#8). Change → so the RHS is always plain , matching what the caller already did before the partial fix that introduced .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
IO::FileDescriptor#sync?returnsBool | Nil. Assigning the raw result tosync=raises a compile-time type error on Crystal 1.20.1 because the union typeBool | Nilis not accepted where plainBoolis expected.The previous attempt to coerce with
!!still passes the union type to the setter and fails under the same checker.Fix
Change
!!buffering→buffering || falseso the RHS is always plainBool.Tested
fff (crystal-port branch) builds and all 131 specs pass with this change applied locally against term-reader ~> 0.3.0.
Cc #8