Skip to content

Fixes and features for restricted environment#42

Open
carl-unique wants to merge 15 commits into
cryptpad:mainfrom
carl-unique:main
Open

Fixes and features for restricted environment#42
carl-unique wants to merge 15 commits into
cryptpad:mainfrom
carl-unique:main

Conversation

@carl-unique
Copy link
Copy Markdown

  • add httpRoute ressources (alternative to ingress) where a GatewayAPI configuration already exists (like envoy)
  • volume/mount fixes, where when someone wants to use customized PVCs, volume creation clashed with extras
  • minor cosmetic fixes
  • removed bitnami dependency, as this is not really needed
  • use global host variables to configure ingress and httpRoute

@carl-unique
Copy link
Copy Markdown
Author

just to have an idea why the mount logic changes

i have one data pvc (cryptpad-data) and i submount the dirs i require like this:

values.yaml

...
  extraVolumes: 
  - name: cryptpad-data
    persistentVolumeClaim:
      claimName: cryptpad-data

  extraVolumeMounts: 
  # -- customizations (logos,..)
  - mountPath: /cryptpad/customize
    name: cryptpad-data
    subPath: customize
  # -- filePath - userdata
  - mountPath: /cryptpad/datastore
    name: cryptpad-data
    subPath: datastore
  # -- blobPath
  - mountPath: /cryptpad/blob
    name: cryptpad-data
    subPath: blob
  # -- blockPath
  - mountPath: /cryptpad/block
    name: cryptpad-data
    subPath: block
...

with this one can mix and choose (the already existing extra volume replaces the emptyDir in that case

@narutolied
Copy link
Copy Markdown
Contributor

+1. looks like a realy good change, should definitely be merged.

@gsautner
Copy link
Copy Markdown
Contributor

Hello,

Thanks for contributing.

Will be merged. I just need extra time here to properly test changes on OpenDesk deployments that we mostly use this chart for.

I will just recommend for future PRs that you don't group numerous changes in a single PR. Having more specific PRs helps a lot on review, and sometimes single changes that require more review/tests don't hold other changes to be applied.
All changes can be applied quickly only with a review. But change in ingress will require a bit more effort to properly review.

@carl-unique
Copy link
Copy Markdown
Author

Hi, sorry, yes you're right, will do that next time. Its ok for me if you cherry pick changes or just open your own branches and just copy it in change by change, im just glad i could provide some stuff so that i do not have to use my own git patches in my private repo, which clashed with your recent changes, anymore.

I also can just close the issue and can split the commits into branches and make MRs out of it if you feel more comfortable with that.

Also maybe update the contribution guide to have a certain framework on howto operate, when doing contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants