Fixes and features for restricted environment#42
Conversation
carl-unique
commented
May 28, 2026
- add httpRoute ressources (alternative to ingress) where a GatewayAPI configuration already exists (like envoy)
- volume/mount fixes, where when someone wants to use customized PVCs, volume creation clashed with extras
- minor cosmetic fixes
- removed bitnami dependency, as this is not really needed
- use global host variables to configure ingress and httpRoute
…ndency (apps/v1 is default)
…e quoted but bool, float and int not
…er sandboxDomain config
…ore than one instance anyway?
… emptyDirs or VolClaims
|
just to have an idea why the mount logic changes i have one data pvc (cryptpad-data) and i submount the dirs i require like this: values.yaml with this one can mix and choose (the already existing extra volume replaces the emptyDir in that case |
|
+1. looks like a realy good change, should definitely be merged. |
|
Hello, Thanks for contributing. Will be merged. I just need extra time here to properly test changes on OpenDesk deployments that we mostly use this chart for. I will just recommend for future PRs that you don't group numerous changes in a single PR. Having more specific PRs helps a lot on review, and sometimes single changes that require more review/tests don't hold other changes to be applied. |
|
Hi, sorry, yes you're right, will do that next time. Its ok for me if you cherry pick changes or just open your own branches and just copy it in change by change, im just glad i could provide some stuff so that i do not have to use my own git patches in my private repo, which clashed with your recent changes, anymore. I also can just close the issue and can split the commits into branches and make MRs out of it if you feel more comfortable with that. Also maybe update the contribution guide to have a certain framework on howto operate, when doing contributions. |