Skip to content

waf: track id/name pairs for all subrules#4505

Open
blotus wants to merge 1 commit into
masterfrom
waf-or-rule-name
Open

waf: track id/name pairs for all subrules#4505
blotus wants to merge 1 commit into
masterfrom
waf-or-rule-name

Conversation

@blotus

@blotus blotus commented Jun 8, 2026

Copy link
Copy Markdown
Member

Fixes #4340

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus blotus added this to the Next release milestone Jun 8, 2026
@blotus

blotus commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

/kind fix

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.89%. Comparing base (b962bc0) to head (16c7594).

Files with missing lines Patch % Lines
cmd/crowdsec-cli/cliitem/hubappsec.go 0.00% 2 Missing ⚠️
pkg/appsec/appsec_rules_collection.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4505      +/-   ##
==========================================
- Coverage   63.89%   63.89%   -0.01%     
==========================================
  Files         478      478              
  Lines       34298    34301       +3     
==========================================
+ Hits        21915    21916       +1     
- Misses      10227    10229       +2     
  Partials     2156     2156              
Flag Coverage Δ
bats 46.50% <76.19%> (-0.01%) ⬇️
unit-linux 37.40% <80.95%> (+0.06%) ⬆️
unit-windows 26.08% <80.95%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WAF rules report wrong name if using an or condition

1 participant