Skip to content

feat: Task API update#266

Merged
andrii-bodnar merged 1 commit intomasterfrom
task-api-update
Mar 27, 2026
Merged

feat: Task API update#266
andrii-bodnar merged 1 commit intomasterfrom
task-api-update

Conversation

@bhdnb
Copy link
Copy Markdown
Collaborator

@bhdnb bhdnb commented Mar 24, 2026

No description provided.

@bhdnb bhdnb self-assigned this Mar 24, 2026
@bhdnb bhdnb marked this pull request as draft March 24, 2026 15:21
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.30%. Comparing base (a094315) to head (e66170a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #266      +/-   ##
============================================
+ Coverage     93.06%   93.30%   +0.25%     
- Complexity     1787     1840      +53     
============================================
  Files           169      169              
  Lines          4850     4969     +119     
============================================
+ Hits           4513     4636     +123     
+ Misses          337      333       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhdnb bhdnb linked an issue Mar 24, 2026 that may be closed by this pull request
@bhdnb bhdnb force-pushed the task-api-update branch from 3016118 to 029ae20 Compare March 24, 2026 15:29
@bhdnb bhdnb marked this pull request as ready for review March 24, 2026 15:32
@bhdnb bhdnb requested a review from andrii-bodnar March 24, 2026 15:32
@andrii-bodnar andrii-bodnar requested a review from Copilot March 24, 2026 15:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Task-related API surface and models to reflect newer Crowdin Task payloads/endpoints, and aligns unit tests accordingly.

Changes:

  • Expanded Task / TaskForUpdate models to include additional task fields (batch, URLs, labels, costs, etc.) and new update filters.
  • Added TaskApi::listTasks($userId, ...) for /users/{userId}/tasks and refreshed API docblocks.
  • Refactored multiple tests to use updated task fixtures and json_encode(...)-based mock responses.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/CrowdinApiClient/Model/Task.php Adds many new Task fields/getters; restructures/relocates some properties and methods.
src/CrowdinApiClient/Model/TaskForUpdate.php Adds new update-related fields (splitContent, stringIds, translationsUpdatedDateFrom/To) and changes initialization.
src/CrowdinApiClient/Api/TaskApi.php Renames/clarifies docstrings, adds listTasks(), and adjusts method formatting.
src/CrowdinApiClient/Api/TaskCommentApi.php Docstring wording updated to clarify “Project Task” scope.
tests/CrowdinApiClient/Api/TaskApiTest.php Updates mocks to json_encode and adds coverage for listTasks().
tests/CrowdinApiClient/Model/TaskTest.php Updates task fixture shape and expands load/set assertions for new fields.
tests/CrowdinApiClient/Model/TaskForUpdateTest.php Updates fixture and extends load/set assertions for new update fields.
tests/CrowdinApiClient/Model/TaskCommentTest.php Simplifies test structure and assertions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bhdnb bhdnb force-pushed the task-api-update branch 3 times, most recently from 16e4f65 to 6cf84d5 Compare March 26, 2026 18:30
@bhdnb bhdnb force-pushed the task-api-update branch from 6cf84d5 to e66170a Compare March 26, 2026 18:32
@andrii-bodnar andrii-bodnar merged commit f3bca05 into master Mar 27, 2026
13 checks passed
@andrii-bodnar andrii-bodnar deleted the task-api-update branch March 27, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tasks API updates

3 participants