Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
============================================
+ Coverage 93.06% 93.30% +0.25%
- Complexity 1787 1840 +53
============================================
Files 169 169
Lines 4850 4969 +119
============================================
+ Hits 4513 4636 +123
+ Misses 337 333 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
There was a problem hiding this comment.
Pull request overview
Updates the Task-related API surface and models to reflect newer Crowdin Task payloads/endpoints, and aligns unit tests accordingly.
Changes:
- Expanded
Task/TaskForUpdatemodels to include additional task fields (batch, URLs, labels, costs, etc.) and new update filters. - Added
TaskApi::listTasks($userId, ...)for/users/{userId}/tasksand refreshed API docblocks. - Refactored multiple tests to use updated task fixtures and
json_encode(...)-based mock responses.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/CrowdinApiClient/Model/Task.php |
Adds many new Task fields/getters; restructures/relocates some properties and methods. |
src/CrowdinApiClient/Model/TaskForUpdate.php |
Adds new update-related fields (splitContent, stringIds, translationsUpdatedDateFrom/To) and changes initialization. |
src/CrowdinApiClient/Api/TaskApi.php |
Renames/clarifies docstrings, adds listTasks(), and adjusts method formatting. |
src/CrowdinApiClient/Api/TaskCommentApi.php |
Docstring wording updated to clarify “Project Task” scope. |
tests/CrowdinApiClient/Api/TaskApiTest.php |
Updates mocks to json_encode and adds coverage for listTasks(). |
tests/CrowdinApiClient/Model/TaskTest.php |
Updates task fixture shape and expands load/set assertions for new fields. |
tests/CrowdinApiClient/Model/TaskForUpdateTest.php |
Updates fixture and extends load/set assertions for new update fields. |
tests/CrowdinApiClient/Model/TaskCommentTest.php |
Simplifies test structure and assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
16e4f65 to
6cf84d5
Compare
andrii-bodnar
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.