[5.0] ironic: Install deploy image with ironic#2406
[5.0] ironic: Install deploy image with ironic#2406skazi0 wants to merge 1 commit intocrowbar:stable/5.0-pikefrom
Conversation
The official SUSE deploy image package will be installed by default together with ironic-server role. Kernel and ramdisk images will be uploaded to glance. (cherry picked from commit a9507ce)
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| code "#{openstack_cmd} #{openstack_args_glance} image create \ | ||
| --disk-format ari --container-format ari --public \ | ||
| --file #{image_path}/initrd #{ramdisk_image_prefix}-#{image_version_cmd}" | ||
| not_if "#{openstack_cmd} #{openstack_args_glance} image list -f value -c Name | grep -q #{ramdisk_image_prefix}-#{image_version_cmd}" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [135/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
| code "#{openstack_cmd} #{openstack_args_glance} image create \ | ||
| --disk-format aki --container-format aki --public \ | ||
| --file #{image_path}/vmlinux #{kernel_image_prefix}-#{image_version_cmd}" | ||
| not_if "#{openstack_cmd} #{openstack_args_glance} image list -f value -c Name | grep -q #{kernel_image_prefix}-#{image_version_cmd}" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [134/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
| # openstack-ironic-image.x86_64-9.0.0.kernel.4.12.14-95.13-default | ||
| # find all x.y.z version substrings and pick the first one to be used | ||
| # as version suffix | ||
| image_version_cmd = "$(readlink #{image_path}/vmlinux | egrep -o '[0-9]+\\.[0-9]+\\.[0-9]+' | head -n1)" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [104/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
|
mkcloud ironic CI failed, that'll need to be fixed first. |
|
@JanZerebecki this is a chicken/egg problem. This PR is part of work which was supposed to lead to a working ironic CI. IIRC there were some other problems which were causing CI failures in SOC8 ironic but I'm not sure if it's worth the effort to get back to fixing this. |
|
So that means this doesn't break anything? Then we can merge it. |
|
It should not break anything. |
2 participants
The official SUSE deploy image package will be installed by default
together with ironic-server role. Kernel and ramdisk images will be
uploaded to glance.
(cherry picked from commit a9507ce)
port of #2100
NOTE This is needed to enable functional ironic testing in SOC8 CI