desginate: Add mdns as hidden master by sjamgade · Pull Request #2105 · crowbar/crowbar-openstack

sjamgade · 2019-04-15T17:13:38Z

in crowbar's world the dns-master is the master of all and slaves
forward all queries to dns-master. Under such a configuration there is
no need to query other nameservers as they still forward the query to
dns-master. So designate can just verify on one nameserver(dns-master)
and dns-master will take care of passing that info to all slaves.

Same goes for also_notifies: dns-master will notify all slaves in case
of either zone or recordset is updated/deleted.

this also further simplifies the designate pool config reducing the
time required to create zone and recordsets.

This change is not really required but only eases out the config from
an admin perspective.

Also having multiple nameservers confuses designate in some times as
according to these nameserver designate is not authoritative of these
zones and recordsets.

This reverts commit 64e7ad9. We've are very close to the release and have multiple pull requests still open for Designate: * crowbar#2095 * crowbar#2104 * crowbar#2105 * SUSE-Cloud/doc-cloud#931 There are way too many question marks on this so I am switching the barclamp back to invisible mode. Lets get these pull requests squared away carefully and without the rush of imminent release.

cmurphy

This change is not really required but only eases out the config from
an admin perspective.

If this isn't critical maybe it could wait till the MU?

cmurphy · 2019-04-15T20:38:54Z

chef/cookbooks/designate/recipes/mdns.rb

If I understand this correctly, the user doesn't have control over this from the barclamp side so they are stuck with this "sample" in their configuration?

this is just a sample file, the user has to edit this file and inject this pool in designate

How can the user edit this file if it's being controlled by crowbar? Chef will just overwrite it.

you can create your own pool rather than the default pool. I think the tricky part here is that you would need to change the pool to use in the designate config. that isn't done yet.

How can the user edit this file if it's being controlled by crowbar? Chef will just overwrite it.

Chef will overwrite file /etc/designate/pools.crowbar.yaml designate relies on /etc/designate/pools.yaml so the user can overwrite the real file or just pass that config to the designate with command documented here SUSE-Cloud/doc-cloud#909

sjamgade · 2019-04-16T14:19:12Z

This code change has no impact on any part of crowbar apart from changing the sample file. But helps greatly in trying to understand what this file really means.

sjamgade · 2019-04-16T14:24:41Z

╰─ irb
irb(main):001:0> dnsmaster='123.123.123.123'
=> "123.123.123.123"
irb(main):002:0> dns = {:fqdn => 'me.exmaple.com' }
=> {:fqdn=>"me.exmaple.com"}
irb(main):003:0> network_settings = {:mdns_bind_host  => dnsmaster }
=> {:mdns_bind_host=>"123.123.123.123"}
irb(main):004:0> pools = [{
irb(main):005:2*   "name" => "default-bind",
irb(main):006:2*   "description" => "Sample Pool for designate (relies only 1 dns-master)",
irb(main):007:2*   "id" => "794ccc2c-d751-44fe-b57f-8894c9f5c842",
irb(main):008:2*   "attributes" => {},
irb(main):009:2*   "ns_records" => [{ "hostname" => "#{dns[:fqdn]}.", "priority" => 1 }],
irb(main):010:2*   "nameservers" => [{ "host" => dnsmaster, "port" => 53 }],
irb(main):011:2*   "also_notifies" => [],
irb(main):012:2*   "targets" => [{
irb(main):013:4*     "type" => "bind9",
irb(main):014:4*     "description" => "BIND9 Server 1",
irb(main):015:4*     "masters" => [{ "host" => network_settings[:mdns_bind_host], "port" => 5354 }],
irb(main):016:4*     "options" => {
irb(main):017:5*       "host" => dnsmaster,
irb(main):018:5*       "port" => 53,
irb(main):019:5*       "rndc_host" => dnsmaster,
irb(main):020:5*       "rndc_port" => 953,
irb(main):021:5*       "rndc_key_file" => "/etc/designate/rndc.key"
irb(main):022:5>     }
irb(main):023:4>   }]
irb(main):024:2> }]
=> [{"name"=>"default-bind", "description"=>"Sample Pool for designate (relies only 1 dns-master)", "id"=>"794ccc2c-d751-44fe-b57f-8894c9f5c842", "attributes"=>{}, "ns_records"=>[{"hostname"=>"me.exmaple.com.", "priority"=>1}], "nameservers"=>[{"host"=>"123.123.123.123", "port"=>53}], "also_notifies"=>[], "targets"=>[{"type"=>"bind9", "description"=>"BIND9 Server 1", "masters"=>[{"host"=>"123.123.123.123", "port"=>5354}], "options"=>{"host"=>"123.123.123.123", "port"=>53, "rndc_host"=>"123.123.123.123", "rndc_port"=>953, "rndc_key_file"=>"/etc/designate/rndc.key"}}]}]
(failed reverse-i-search)`': import^C
irb(main):025:0> require 'yaml'
=> true
irb(main):026:0> pools.to_yaml
=> "---\n- name: default-bind\n  description: Sample Pool for designate (relies only 1 dns-master)\n  id: 794ccc2c-d751-44fe-b57f-8894c9f5c842\n  attributes: {}\n  ns_records:\n  - hostname: me.exmaple.com.\n    priority: 1\n  nameservers:\n  - host: 123.123.123.123\n    port: 53\n  also_notifies: []\n  targets:\n  - type: bind9\n    description: BIND9 Server 1\n    masters:\n    - host: 123.123.123.123\n      port: 5354\n    options:\n      host: 123.123.123.123\n      port: 53\n      rndc_host: 123.123.123.123\n      rndc_port: 953\n      rndc_key_file: \"/etc/designate/rndc.key\"\n"

sjamgade · 2019-05-08T09:43:57Z

this change is now needed for HA, I have added comments to the code and update the commit message to reflect why this change is required.

guangyee

code looks good

sjamgade · 2019-05-09T13:41:16Z

Rebased with HA fix

This reverts commit 64e7ad9. We've are very close to the release and have multiple pull requests still open for Designate: * crowbar#2095 * crowbar#2104 * crowbar#2105 * SUSE-Cloud/doc-cloud#931 There are way too many question marks on this so I am switching the barclamp back to invisible mode. Lets get these pull requests squared away carefully and without the rush of imminent release.

cmurphy · 2019-05-29T15:43:14Z

chef/cookbooks/designate/recipes/mdns.rb

would be nice to correct the typo here and in the commit message ("corsspoding")

cmurphy · 2019-05-29T15:43:29Z

chef/cookbooks/designate/recipes/mdns.rb

and here ("th") and in the commit message

dirkmueller

Please at least make the list of nameservers expand all hosts again. Ideally the hostname ns_record would be configurable (as it needs to point to the public hostname), but thats not a new bug introduced here

dirkmueller · 2019-07-09T05:36:28Z

chef/cookbooks/designate/recipes/mdns.rb

Why this change? IMHO it should be the default pool, this matches the name line above.

dirkmueller · 2019-07-09T05:41:23Z

chef/cookbooks/designate/recipes/mdns.rb

+  "description" => "Sample Pool for designate",
  "id" => "794ccc2c-d751-44fe-b57f-8894c9f5c842",
  "attributes" => {},
  "ns_records" => [{ "hostname" => "#{dns[:fqdn]}.", "priority" => 1 }],


This would need to be configurable in the barclamp.

dirkmueller · 2019-07-09T07:28:17Z

chef/cookbooks/designate/recipes/mdns.rb

this part doesn't make a whole lot of sense to me. this way we have only one DNS server hosting the domain, with other words no High Availability (HA is a requirement, see https://jira.suse.com/browse/SOC-6361 ). We need to list all dns-server masters here, and ideally their public IP address (see SOC-9635 )

nameservers is a list where designate will check if the zone and/or ns-record is created successfully, I have limited it to 1 server and that too dns-master. because ....

The DNS barclamp has only 1 dns-server as master. All others are slaves who just forward incoming request to that master (this how bind is configured). This dns-master stores all the zone and ns-records received from designate.

These slaves could also be part of nameservers where designate validates the creation of zones and ns-records, but that wasnt very useful since they are just going to forwards query to dns-master.

dirkmueller · 2019-07-09T07:29:09Z

chef/cookbooks/designate/recipes/mdns.rb

-  "nameservers" => dnsservers.map { |ip| { "host" => ip, "port" => 53 } },
-  "also_notifies" => dnsslaves.map { |ip| { "host" => ip, "port" => 53 } },
+  "nameservers" => [{ "host" => dnsmaster, "port" => 53 }],
+  "also_notifies" => [],


leaving this empty by default makes sense to me, however if this is integrated in another hidden master setup (like e.g. SUSE's internal DNS), you need to be able to add additional hosts here. ideally this would be a setting in the barclamp ui.

dirkmueller · 2019-07-09T07:30:22Z

chef/cookbooks/designate/recipes/mdns.rb

this is already in the list above, right? just once via vip and once via the node ip. I don't understand why we need to add it twice?

afaik Barclamp::Inventory.get_network_by_type does not return the VIP so the list has admin address,

Also iiuc the that is different from VIP, and the host with VIP will use that ip as the outgoing ip when connecting to the real-master.

ritesh216 · 2019-08-16T20:29:46Z

Addressing the open review comments in the next commit. Note, "nameservers" will be updated via SCRD-9636 to use public FQDNs.

comments addressed.

ritesh216

WIP

In crowbar's world the dns-master is the master of all and slaves forward all queries to dns-master. When designate is enabled, designate-mdns service component(s) become the hidden master(s). We leave 'also_notifies' empty. It can be configured by the users via designate-manage utility as and when needed. designate-mdns service components, in HA, will be running on multiple hosts and any host can be asked to update a zone on th real-master. We add the cluster vip as the hidden master in case HA is enabled otherwise add all servers.

jgrassler mentioned this pull request Apr 15, 2019

Revert "designate: show barclamp" #2106

Merged

cmurphy reviewed Apr 15, 2019

View reviewed changes

sjamgade requested a review from jgrassler April 16, 2019 14:19

cmurphy previously approved these changes Apr 16, 2019

View reviewed changes

sjamgade dismissed cmurphy’s stale review via 2e89f84 May 8, 2019 09:43

sjamgade force-pushed the rocky_designatesimplify branch from 315171a to 2e89f84 Compare May 8, 2019 09:43

guangyee previously approved these changes May 8, 2019

View reviewed changes

sjamgade dismissed guangyee’s stale review via 3fe0370 May 9, 2019 13:41

sjamgade force-pushed the rocky_designatesimplify branch from 2e89f84 to 3fe0370 Compare May 9, 2019 13:41

sjamgade force-pushed the rocky_designatesimplify branch from 3fe0370 to c61534d Compare May 20, 2019 18:09

cmurphy previously approved these changes May 29, 2019

View reviewed changes

sjamgade dismissed cmurphy’s stale review via 400008a July 3, 2019 09:46

sjamgade force-pushed the rocky_designatesimplify branch 2 times, most recently from 400008a to 03a5d0b Compare July 3, 2019 09:48

jgrassler previously approved these changes Jul 3, 2019

View reviewed changes

dirkmueller previously requested changes Jul 9, 2019

View reviewed changes

ritesh216 dismissed jgrassler’s stale review via 82ff9bb August 16, 2019 20:45

ritesh216 force-pushed the rocky_designatesimplify branch from 03a5d0b to 82ff9bb Compare August 16, 2019 20:45

ritesh216 requested a review from dirkmueller August 16, 2019 20:48

ritesh216 force-pushed the rocky_designatesimplify branch from 82ff9bb to 081e89f Compare August 16, 2019 20:54

ritesh216 force-pushed the rocky_designatesimplify branch 2 times, most recently from b90aeaf to 4757bda Compare August 21, 2019 22:21

ritesh216 changed the title ~~desginate: simplify sample pool~~ desginate: Add mdns as hidden master Aug 21, 2019

ritesh216 reviewed Aug 21, 2019

View reviewed changes

ritesh216 force-pushed the rocky_designatesimplify branch from 4757bda to a8f2c73 Compare August 23, 2019 21:43

JanZerebecki added the wip label Jan 12, 2021

Conversation

sjamgade commented Apr 15, 2019

Uh oh!

cmurphy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dirkmueller Apr 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sjamgade commented Apr 16, 2019

Uh oh!

sjamgade commented Apr 16, 2019

Uh oh!

sjamgade commented May 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guangyee left a comment

Choose a reason for hiding this comment

Uh oh!

sjamgade commented May 9, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dirkmueller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ritesh216 commented Aug 16, 2019

Uh oh!

ritesh216 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

Comments

dirkmueller Apr 16, 2019 •

edited

Loading

sjamgade commented May 8, 2019 •

edited

Loading