monasca: configure keystone admin user#1939
Open
matrixik wants to merge 1 commit into
Open
Conversation
Contributor
|
@matrixik thanks! Could you extend the commit msg a bit to clarify why this is needed and what failure it shoudl fix? |
Contributor
Author
|
@toabctl Done. |
toabctl
previously approved these changes
Dec 17, 2018
witekest
reviewed
Dec 17, 2018
witekest
previously approved these changes
Dec 17, 2018
toabctl
previously approved these changes
Dec 17, 2018
jgrassler
approved these changes
Dec 17, 2018
jgrassler
requested changes
Dec 17, 2018
jgrassler
left a comment
jgrassler
left a comment
Contributor
There was a problem hiding this comment.
Apologies for withdrawing my +1 but there's one thing I just noticed about the commit message we should change: could you please change it to monasca: configure keystone admin project (bsc#1119070)? We need a reference to the bug we are fixing in there.
Now when installing Monasca, installer is always configured with Keystone admin user and project set to `admin` and it's imposible to change it. Whith this change undelying Ansible runner will be configured with proper Keystone settings.
Contributor
Author
|
@jgrassler Done |
dirkmueller
approved these changes
Dec 18, 2018
toabctl
approved these changes
Dec 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.