Open
Conversation
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this requires a fix to the upstream repo before we can merge it, see stephenh/ts-proto#1216
Description of your changes
Add TypeScript Type Registry Support for Protobuf Type Detection
Summary
This PR enhances the SDK's ability to detect and work with protobuf types by enabling the
outputTypeRegistry=trueoption inprotoc-gen-ts_proto. This adds a$typeproperty to all generated protobuf types, providing a reliable type identifier that simplifies type detection throughout the codebase.Changes
1. Generated Protobuf Code
typeRegistry.ts: Created the type registry file that provides themessageTypeRegistryMap and type definitions used by all generated protobuf code$typeproperty with their fully-qualified type name (e.g.,"apiextensions.fn.proto.v1.Resource")fromPartial()methods inrun_function.tsto useas unknown asfor safer type casting when dealing with Object.entries()2. Improved Type Detection in
resource.tsBefore:
Benefits:
Test Updates
Updated response.test.ts to expect the $type property in SchemaSelector objects:
I have: