enhance log color detection and default to colored logs in docker#2150
Open
markope wants to merge 2 commits intocrossbario:masterfrom
Open
enhance log color detection and default to colored logs in docker#2150markope wants to merge 2 commits intocrossbario:masterfrom
markope wants to merge 2 commits intocrossbario:masterfrom
Conversation
added 2 commits
December 31, 2025 12:33
- Add support for NO_COLOR environment variable to disable colors - Add support for FORCE_COLOR and CLICOLOR_FORCE to enable colors - Default to enabling colors when not a TTY (better Docker log display) - Follows standard color control conventions (https://no-color.org/)
Contributor
Author
|
Fixes #2150 |
Contributor
the just recipes are exactly what github actions uses as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support NO_COLOR/FORCE_COLOR environment variables for log output
Description
This PR improves log color detection to support standard environment variables and provide better defaults for containerized environments.
Changes
NO_COLORenvironment variable to disable colors (no-color.org)FORCE_COLORandCLICOLOR_FORCEenvironment variables to enable colorsMotivation
When running crossbar in Docker or other non-TTY environments, log colors were always disabled because
sys.__stdout__.isatty()returnsFalse. This made logs harder to read when viewing viadocker logsor in CI/CD systems that support ANSI colors.Usage
Breaking Changes
Minor: Logs in non-TTY environments will now show colors by default. Set
NO_COLOR=1to restore previous behavior.Checklist