Initial version of UI tests.#1115
Conversation
|
I think instead of having methods to check the output we can have this way we can also present a diff and ensure every aspect is captured. But this is definitely an interesting approach and may work very well 👍🏼 |
8c32d27 to
fe0208f
Compare
|
I've added the initial versions of |
13eb114 to
a1f74d6
Compare
|
I've completed reworked how CLI parsing works, and added an extensive set of integration tests. By default, these are ignored because they're very slow to run. I've also added in a regression test for #1141. I've ensured this only runs once per target. The ignored unittests are also run in the main |
| trycmd = "0.14.4" | ||
| snapbox = "0.4" |
There was a problem hiding this comment.
We could have this as its own workspace member alongside cross and xtask, not needed but just a thought
There was a problem hiding this comment.
Is there any major advantage to that over faster compile times for the test suite? Not saying that isn't a good goal, just wondering if there's something additional as well.
|
This needs to handle escape sequences as well: I've used |
| ci_dir=$(realpath "${ci_dir}") | ||
| . "${ci_dir}"/shared.sh | ||
|
|
||
| main() { |
There was a problem hiding this comment.
This needs a clippy -- --deny warnings just to ensure that -Zbuild-std is getting correctly added as well.
a1f74d6 to
1032203
Compare
This is a very initial draft, but the idea is to add UI tests (which we'll add more as this gets further along).
UI tests still to add:
Any suggestions for additional UI tests to add, please suggest them below. This also needs to add
ci/test-ui.shinto the CI. This will close #1037. I'm also waiting for #1103 to be closed so I can add it to the UI tests.