[TCE] Srpskohrvatski web version#4971
Merged
just1602 merged 4 commits intocrimethinc:mainfrom Feb 1, 2026
Merged
Conversation
Bargraph6
force-pushed
the
tce-serbocroation
branch
2 times, most recently
from
347c088 to
41d7df1
Compare
Bargraph6
changed the title
Bargraph6
requested review from
astronaut-wannabe,
bookis,
eliduke,
evanphx,
guitsaru,
just1602 and
veganstraightedge
as code owners
Contributor
Author
|
this is ready for review |
just1602
force-pushed
the
tce-serbocroation
branch
from
41d7df1 to
56aa85d
Compare
just1602
reviewed
Jan 15, 2026
Collaborator
|
Other then the small comment to address, this LGTM. |
Bargraph6
force-pushed
the
tce-serbocroation
branch
from
f625e3c to
07a0b05
Compare
This initial pass on converting the Srpskohrvatski PDF to the web version slots in all of the translations available in the PDF. There are things that need to be translated that are not in the PDF, such as menu items (e.g. "Download PDF"), certain headers (e.g. "The secret is to begin"), image alt text, etc. Normally I throw these things into google translate, as the original translators are unavailable. I have done that here also, with an extra complication I wanted to call out. The text is is serbocroation, which isn't an option in google translate. I went with "bosnian" in google translate as that was the most common "autodetected" language when I pasted in different sections of the PDF translations. --- resolves: crimethinc#1397 related to: crimethinc#575
Bargraph6
force-pushed
the
tce-serbocroation
branch
from
fec17ab to
32e5581
Compare
Contributor
Author
@just1602 I have rebased and applied your fix |
just1602
approved these changes
Feb 1, 2026
Contributor
|
@Bargraph6 thank you for doing these TCE implementations! 🎉 My apologies for being slow to review/merge/deploy. :/ @just1602 thank you for stepping up to do the review/merge! :) |
Contributor
Author
@veganstraightedge no worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant GitHub issues?
resolves: #1397
related to: #575
What does this pull request do?
This converts the Srpskohrvatski PDF to the web version using the translations available in the PDF.
How should this be manually tested?
looking at the page with various screen sizes
Is there any background context you want to provide for reviewers?
There are things that need to be translated that are not in the PDF,
such as menu items (e.g. "Download PDF"), certain headers (e.g. "The
secret is to begin"), image alt text, etc.
Normally I throw these things into google translate, as the original
translators are unavailable.
I have done that here also, with an extra complication I wanted to
call out. The text is is serbocroation, which isn't an option in
google translate. I went with "bosnian" in google translate as that
was the most common "autodetected" language when I pasted in different
sections of the PDF translations.