fix: clear CodeQL weak sensitive hashing on model catalog cache key (#64) - #6827
Draft
theCyberTech wants to merge 1 commit into
Draft
fix: clear CodeQL weak sensitive hashing on model catalog cache key (#64)#6827theCyberTech wants to merge 1 commit into
theCyberTech wants to merge 1 commit into
Conversation
SHA-256 of API key material in _cache_key trips py/weak-sensitive-data-hashing (CodeQL alert #64). Use HMAC-SHA256 with the credential as the key and a fixed app message so the cache partition id stays non-reversible without password-style hashing. Co-authored-by: Rip&Tear <theCyberTech@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeQL alert #64:
py/weak-sensitive-data-hashingincrewai_cli.model_catalog._cache_key.After
#6815includedlib/cliin CodeQL paths, scanning flagged:CodeQL classifies
api_keyas password-like material, so plain SHA-256 is treated as insecure password hashing.Fix
Use HMAC-SHA256 with the API key as the HMAC key and a fixed app string as the message:
This keeps a short, non-reversible local cache partition id (raw keys are still never stored) without password-style hashing of the credential.
Validation
python-code-scanningsuite: 0 results (was 1×py/weak-sensitive-data-hashing)pytest lib/cli/tests/test_model_catalog.py: 39 passed