feat(memory): add result_items provenance to MemoryQueryCompletedEvent#6173
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
Conversation
Adds structured per-item provenance to MemoryQueryCompletedEvent so benchmark runners can trace individual memory entries without leaking embedding vectors. Each result_item contains: record_id, content, scope, categories, metadata, source, private, importance, created_at, last_accessed, score, match_reasons, and evidence_gaps. Fixes crewAIInc#5800
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds structured per-item provenance to
MemoryQueryCompletedEventso benchmark runners can trace individual memory entries without leaking embedding vectors.Problem
Issue #5800: Bench'd Independent Benchmark Results for CrewAI Memory showed that aggregate scores mask per-item failures. The
MemoryQueryCompletedEventemitted byMemory.remember()andMemory.recall()had no structured way to trace which specific memory entries were retrieved, their sources, scores, and match reasons.Solution
Add
result_items: list[dict[str, Any]]toMemoryQueryCompletedEvent. Each item contains:record_idcontentscopecategoriesmetadatasourceprivateimportancecreated_atlast_accessedscorematch_reasonsevidence_gapsEmbeddings are intentionally excluded from serialization to prevent vector data leakage into traces and benchmark reports.
Changes
crewai/events/types/memory_events.py: Addedresult_itemsfield toMemoryQueryCompletedEventcrewai/memory/unified_memory.py: Populateresult_itemsat event emission timetests/memory/test_unified_memory.py: Tests for the new fieldVerification
127 memory tests pass. ruff and mypy clean on changed files.
Closes #5800