-
Notifications
You must be signed in to change notification settings - Fork 7k
fix: support Azure endpoints other than openai.azure.com #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devin-ai-integration
wants to merge
1
commit into
main
from
devin/1768991651-fix-azure-endpoint-detection
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Copilot Autofix
AI 3 months ago
In general, the problem should be fixed by parsing the endpoint as a URL, extracting its hostname, and performing checks against that hostname (and possibly its subdomains), instead of checking the raw endpoint string for substrings like
"openai.azure.com"or".azure.com". This ensures we classify and normalize only real Azure domains and not arbitrary strings that happen to contain those substrings.Concretely for this file:
urlparsefrom Python’s standardurllib.parsemodule at the top of the file (we’re allowed to add well-known standard-library imports)._is_azure_endpointto:urlparse.hostname(lowercased).openai.azure.com,cognitiveservices.azure.com,services.ai.azure.com) and a generic*.azure.comcheck implemented ashostname == "azure.com" or hostname.endswith(".azure.com").in endpointsubstring checks._validate_and_fix_endpointto determine whether the host is an Azure OpenAI host by parsing the URL and checkinghostname == "openai.azure.com"or ending with.openai.azure.com(to support resource-specific subdomains like<resource>.openai.azure.com). Use this boolean instead of"openai.azure.com" in endpoint. This avoids misclassifying URLs likehttps://evil-openai.azure.com.attacker.com./openai/deployments/. The only behavioral change is stricter and correct host recognition.No new third-party dependencies are needed; we only use the standard library.